Remove hideTempErr to allow downstream users to check for errors like net.ErrClosed #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlexVulaj This would fix several issues with the 1.5.1 release. Please take a look. Thanks! |
UnAfraid
changed the title
jaitaiwan
previously approved these changes
Feb 13, 2024
|
I'm happy to merge this @jaitaiwan , feel free to make a final call on the "t.Parallel" comment but I don't have any strong feelings. |
|
Please let me know if t.Parallel() should be used and i can bring it back, i don't mind either way. |
UnAfraid
force-pushed
the
bugfix/net-errors
branch
from
2d899f5
to
52188df
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #894 +/- ##
==========================================
+ Coverage 71.30% 71.38% +0.08%
==========================================
Files 11 11
Lines 1589 1583 -6
==========================================
- Hits 1133 1130 -3
+ Misses 349 347 -2
+ Partials 107 106 -1 ☔ View full report in Codecov by Sentry. |
|
Security and lint failures are unrelated to this change. |
|
Agreed. Thanks for the contribution! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Since this change https://github.com/gorilla/websocket/pull/840/files#diff-4f427d2b022907c552328e63f137561f6de92396d7a6e8f6c2ea1bcf0db52654L190-R197 we can no longer determinate if the errors coming from ReadMessage() are net.ErrClosed for example
Hardcoding the error message is not great option because it may vary from OS to OS and system locale
Related Tickets & Documents
Added/updated tests?
have not been included
Run verifications and test
make verifyis passingmake testis passing