Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed Gorilla WebSocket #353

Closed
FZambia opened this issue Jan 21, 2024 · 1 comment
Closed

Embed Gorilla WebSocket #353

FZambia opened this issue Jan 21, 2024 · 1 comment

Comments

@FZambia
Copy link
Member

FZambia commented Jan 21, 2024

Unfortunately Gorilla Websocket is poorly maintained these days. Some examples:

We have enough expertise here to fork it and maintain for our own needs.

The idea here is to not fork though but embed to internal dir, and possibly only necessary parts of Gorilla WebSocket. The reason of embedding instead of having separate module – I don't want other developers to rely on websocket package API which I suppose may evolve to fit Centrifuge needs and we better keep it internal.

@FZambia
Copy link
Member Author

FZambia commented Feb 3, 2024

Done, this is unfortunate thing in general, but we need to move forward.

@FZambia FZambia closed this as completed Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant