Bump github.com/gorilla/websocket from 1.5.0 to 1.5.1 #2898
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/gorilla/websocket-1.5.1
branch
3 times, most recently
from
c863be3
to
59c2889
Compare
|
@telemenar @UnAfraid @vlad-tokarev @szgupta @zhixinwen Any of you websocket gqlgen contributors know why this upgrade is failing? I would appreciate someone taking a look! Thanks. |
|
@StevenACoffman I'll have a look at it Edit: gorilla/websocket#877 |
|
Thanks so much! |
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/gorilla/websocket-1.5.1
branch
3 times, most recently
from
eb543df
to
1d6ecbd
Compare
|
So gorilla merged @UnAfraid PR (thanks!), but I see a lot of people have had a lot of other problems with gorilla 1.5.1 release. Since I don't use websockets, I'm not clear if it is wise to update gqlgen's gorilla/websocket dependency to the current mainline commit or if we should wait until the 1.5.2 release. People can try it out with: If the current 1.5.0 is working for folks, I'm ok with waiting until 1.5.2, but if 1.5.0 is breaking someone's production, I'm also ok with going forward. I'm going to let the decision rest with gqlgen's Websocket Council of Wisdom™️ @telemenar @UnAfraid @vlad-tokarev @szgupta @zhixinwen |
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/gorilla/websocket-1.5.1
branch
from
1d6ecbd
to
1610a25
Compare
Bumps [github.com/gorilla/websocket](https://github.com/gorilla/websocket) from 1.5.0 to 1.5.1. - [Release notes](https://github.com/gorilla/websocket/releases) - [Commits](gorilla/websocket@v1.5.0...v1.5.1) --- updated-dependencies: - dependency-name: github.com/gorilla/websocket dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/gorilla/websocket-1.5.1
branch
from
1610a25
to
2d825cd
Compare
|
For anyone watching, the 1.5.1 release had a number of problems, which gqlgen contributors have been making patches on. We're going to ignore 1.5.1 and hope that 1.5.2 is in better shape. |
Bumps github.com/gorilla/websocket from 1.5.0 to 1.5.1.
Release notes
Sourced from github.com/gorilla/websocket's releases.
Commits
ac0789bupdate GitHub workflows (#857)78c3487update golang.org/x/net (#856)666c197Update go version & add verification/testing tools (#840)8039329Correct way to save memory using write buffer pool and freeing net.http defau...8983b96Merge pull request #839 from gorilla/coreydaley-patch-1931041cUpdate README.md76ecc29archive modeaf47554check error before GotConn for tracebc7ce89Check for and report bad protocol in TLSClientConfig.NextProtos (#788)27d91a9drop the versions of go that are no longer supported + add 1.18 to ciYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)