Add codemod mode for @glimmer/syntax preparse.
#938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
add-explicit-codemod-mode
branch
from
fb564f2
to
16aa365
Compare
|
looks like #941 caused a conflict here, sorry :( |
Currently, setting `mode` to `'codemod'` will: * Disable `entity` parsing in simple-html-tokenizer (ensures that parsing + printing is not lossy) * Enable `ignoreStandalone` mode in handlebars parser (ensures that standalone whitespace after a block opening or closing is not stripped). In the future we can do other things to make the codemod world even better, but this is a really good first step (IMHO).
Turbo87
force-pushed
the
add-explicit-codemod-mode
branch
from
16aa365
to
458fe54
Compare
|
I rebased it and fixed the conflict :) |
|
restarted CI due to the browserstack timeout. it's 🍏 now. |
4 tasks
|
@rwjblue I commented on the prettier repo but it seems that HTML entity numbers are still being converted: jgwhite/prettier#1 (comment) Is this something @glimmer/syntax could address or we'd have to update prettier for? |
|
@nabeelz6 it's definitely a problem with the glimmer parser |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, setting
modeto'codemod'will:entityparsing in simple-html-tokenizer (ensures that parsing + printing is not lossy WRT entities)ignoreStandalonemode in handlebars parser (ensures that standalone whitespace after a block opening or closing is not stripped).In the future we can do other things to make the codemod world even better, but this is a really good first step (IMHO).