[Glimmer] preserve HTML entities #6234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GavinJoyce
force-pushed
the
gj/fix-glimmer-html-entities
branch
from
caebc99
to
b51d97d
Compare
rwjblue
approved these changes
Jun 19, 2019
GavinJoyce
commented
Jun 19, 2019
| @@ -8,7 +8,8 @@ function parse(text) { | |||
| return glimmer(text, { | |||
| plugins: { | |||
| ast: [] | |||
| } | |||
| }, | |||
| mode: "codemod" | |||
There was a problem hiding this comment.
this mode was introduced here: glimmerjs/glimmer-vm#938
GavinJoyce
changed the title
GavinJoyce
changed the title
lydell
approved these changes
Jun 19, 2019
|
@evilebottnawi you approved the PR that this aims to supersede, likely by mistake. Perhaps you could review this one? |
|
Perhaps we could merge this? Thanks |
lock
bot
added
the
locked-due-to-inactivity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #5300
supersedes #4533
part of jgwhite#1
With the following input:
On master, we get the following incorrect output:
With this PR, the entities are correctly preserved:
(If changing the API or CLI) I’ve documented the changes I’ve made (in thedocs/directory)CHANGELOG.unreleased.mdfile following the template.✨Try the playground for this PR✨