Add support for chained inverse blocks
#942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase (conflicted by #938), I think the main issue will be the updated print-test.ts format... |
rwjblue
approved these changes
May 13, 2019
Passing `Program` nodes to `.block()` is deprecated and does not contain the new `chained` property
|
@rwjblue done |
rwjblue
changed the title
chained inverse blockschained inverse blocks.
rwjblue
changed the title
chained inverse blocks.chained inverse blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that some code was added lately to support the
chainedproperty of the Handlebars AST in the printer, but the parser was not correctly hooked up yet. This PR adds the missing pieces so thatelse ifis correctly represented in the Glimmer AST now.Since the
b.blockItself()signature was changed this should be considered a breaking change.Closes #366
/cc @rwjblue @wycats