Reformatting breaks certain HTML entities

[jpike88]

I use the VSCode extension handlebars-formatter (https://github.com/mfeckie/handlebars-formatter) which relies on prettier (https://github.com/prettier/prettier) which in turn relies on glimmer.

I tried to format this:

<span class="stampFont" style="font-family: 'stampfont'">&#xf000;</span>

That entity is valid HTML and shouldn't be stripped... but it gets changed to this:

<span class="stampFont" style="font-family: 'stampfont'">
  
</span>

[jpike88]

prettier/prettier#10542 (comment)

[jpike88]

@pzuraq what are your thoughts on this one? it's a big problem for me and I'd like to contribute if it's a non-trivial fix.

[pzuraq]

Definitely would be open to a fix, unsure exactly where this would be transforming in the system itself, likely when we first read the text node's content?

[rwjblue]

@jpike88 - We explicitly provide modes that disable entity parsing, seems like they should be leveraging that?

[rwjblue]

See #938

[thorn0]

Prettier uses that setting. Named entities are preserved, numeric character reference aren't.

[jpike88]

This use case is because I have large custom font libraries consisting of symbols.

[rwjblue]

Thank you! I believe that #1284 will fix this (added your snippet as a test case to confirm).

[rwjblue]

Released in https://github.com/glimmerjs/glimmer-vm/releases/tag/v0.77.2

[jpike88]

cheers!