requirement: bump httpx from 0.23.0 to 0.23.3 #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
dependabot
bot
force-pushed
the
dependabot/pip/httpx-0.23.3
branch
6 times, most recently
from
91f6653
to
6fe6734
Compare
francoisfreitag
force-pushed
the
dependabot/pip/httpx-0.23.3
branch
from
75a2175
to
8c8486d
Compare
xavfernandez
reviewed
Jan 5, 2023
| @@ -150,7 +150,9 @@ def test_offres(self): | |||
| json={"resultats": pole_emploi_api_mocks.API_OFFRES}, | |||
| ) | |||
| assert self.api_client.offres(natureContrat="FT", range="0-1") == pole_emploi_api_mocks.API_OFFRES | |||
| respx.get("https://pe.fake/offresdemploi/v2/offres/search?range=100-140").respond(204) | |||
| respx.get("https://pe.fake/offresdemploi/v2/offres/search?typeContrat=&natureContrat=&range=100-140").respond( | |||
There was a problem hiding this comment.
Tu as regardé pourquoi ça passait avant et plus maintenant ? On est d'accord que ce fix du test marche aussi en httpx 0.23.0 ?
There was a problem hiding this comment.
C’est lié à encode/httpx@d5900cd.
Auparavant, HTTPX droppait les query params avec des valeurs vides.
There was a problem hiding this comment.
git tag --contains d5900cd40ec85e47800e21e77bc684b9f65325ed
0.23.1
0.23.2
0.23.3
There was a problem hiding this comment.
Depuis le changelog : encode/httpx#2354
xavfernandez
approved these changes
Jan 5, 2023
Bumps [httpx](https://github.com/encode/httpx) from 0.23.0 to 0.23.3. - [Release notes](https://github.com/encode/httpx/releases) - [Changelog](https://github.com/encode/httpx/blob/master/CHANGELOG.md) - [Commits](encode/httpx@0.23.0...0.23.3) --- updated-dependencies: - dependency-name: httpx dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
The expected querystring was not representative of the call being by the API client.
francoisfreitag
force-pushed
the
dependabot/pip/httpx-0.23.3
branch
from
8c8486d
to
0b0f5a7
Compare
|
Bien vu et merci ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps httpx from 0.23.0 to 0.23.3.
Release notes
Sourced from httpx's releases.
Changelog
Sourced from httpx's changelog.
Commits
08a557eVersion 0.23.3 (#2540)bddd774Revert "RaiseTypeErroron invalid query params. (#2523)" (#2539)e27d1b8replace pytest-asyncio and pytest-trio with anyio (#2512)e4438a3PyPI readme: fix screenshot links & trim changelog (#2522)6a98e18Bump chardet from 5.0.0 to 5.1.0 (#2530)c6084c0Bump mkdocs-material from 8.5.5 to 8.5.11 (#2529)8c91107Bump isort from 5.10.1 to 5.11.4 (#2528)2ab7358Version 0.23.2 (#2510)4cbf13eRaiseTypeErroron invalid query params. (#2523)10a3b68Delete setup.py (#2516)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)