Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back in URL.raw with NamedTuple #2481

Merged
merged 4 commits into from Dec 2, 2022

Conversation

developerDemetri
Copy link
Contributor

@developerDemetri developerDemetri commented Nov 30, 2022

Closes #2462 with a basic test, happy to add tests for more scenarios

Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I'm happy with this.

We could also add a comment on the .raw() method metioning that it is due to be deprecated in a future release, but I don't mind too much either way, so wouldn't consider it a blocker.

@tomchristie
Copy link
Member

Okay, let's go with this.

We'll want a new minor point release.

@tomchristie tomchristie merged commit 40a0da0 into encode:master Dec 2, 2022
@developerDemetri developerDemetri deleted the re-add-url-dot-raw branch December 14, 2022 01:49
@tomchristie tomchristie mentioned this pull request Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking drop of URL.raw in patch release 0.23.1
2 participants