Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requirement: bump httpx from 0.23.0 to 0.23.3 #1943

Merged
merged 2 commits into from
Jan 5, 2023
Merged

requirement: bump httpx from 0.23.0 to 0.23.3 #1943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e89867
requirement: bump httpx from 0.23.0 to 0.23.3
dependabot[bot] Jan 5, 2023
0b0f5a7
Fix PoleEmploiAPIClientTest::test_offres
francoisfreitag Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion itou/utils/apis/test_pole_emploi_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,9 @@ def test_offres(self):
json={"resultats": pole_emploi_api_mocks.API_OFFRES},
)
assert self.api_client.offres(natureContrat="FT", range="0-1") == pole_emploi_api_mocks.API_OFFRES
respx.get("https://pe.fake/offresdemploi/v2/offres/search?range=100-140").respond(204)
respx.get("https://pe.fake/offresdemploi/v2/offres/search?typeContrat=&natureContrat=&range=100-140").respond(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tu as regardé pourquoi ça passait avant et plus maintenant ? On est d'accord que ce fix du test marche aussi en httpx 0.23.0 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C’est lié à encode/httpx@d5900cd.
Auparavant, HTTPX droppait les query params avec des valeurs vides.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

git tag --contains d5900cd40ec85e47800e21e77bc684b9f65325ed
0.23.1
0.23.2
0.23.3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depuis le changelog : encode/httpx#2354

204
)
assert self.api_client.offres(range="100-140") == []

@respx.mock
Expand Down
6 changes: 3 additions & 3 deletions requirements/base.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,9 +261,9 @@ httpcore==0.15.0 \
--hash=sha256:1105b8b73c025f23ff7c36468e4432226cbb959176eab66864b8e31c4ee27fa6 \
--hash=sha256:18b68ab86a3ccf3e7dc0f43598eaddcf472b602aba29f9aa6ab85fe2ada3980b
# via httpx
httpx==0.23.0 \
--hash=sha256:42974f577483e1e932c3cdc3cd2303e883cbfba17fe228b0f63589764d7b9c4b \
--hash=sha256:f28eac771ec9eb4866d3fb4ab65abd42d38c424739e80c08d8d20570de60b0ef
httpx==0.23.3 \
--hash=sha256:9818458eb565bb54898ccb9b8b251a28785dd4a55afbc23d0eb410754fe7d0f9 \
--hash=sha256:a211fcce9b1254ea24f0cd6af9869b3d29aba40154e947d2a07bb499b3e310d6
# via -r requirements/base.in
huey==2.4.4 \
--hash=sha256:6a27a7862a7a982c0508ad4e548d95765e3b0d97093a51106f07540837a09c86
Expand Down
6 changes: 3 additions & 3 deletions requirements/dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,9 +470,9 @@ httpcore==0.15.0 \
# via
# -r requirements/base.txt
# httpx
httpx==0.23.0 \
--hash=sha256:42974f577483e1e932c3cdc3cd2303e883cbfba17fe228b0f63589764d7b9c4b \
--hash=sha256:f28eac771ec9eb4866d3fb4ab65abd42d38c424739e80c08d8d20570de60b0ef
httpx==0.23.3 \
--hash=sha256:9818458eb565bb54898ccb9b8b251a28785dd4a55afbc23d0eb410754fe7d0f9 \
--hash=sha256:a211fcce9b1254ea24f0cd6af9869b3d29aba40154e947d2a07bb499b3e310d6
# via
# -r requirements/base.txt
# respx
Expand Down