Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Raise TypeError on invalid query params. (#2523)" #2539

Merged
merged 1 commit into from Jan 4, 2023

Conversation

zanieb
Copy link
Contributor

@zanieb zanieb commented Jan 3, 2023

This reverts commit 4cbf13e / PR #2523

See discussion at #2538 and in #2523 — this change is potentially breaking and should be considered for a future release instead (i.e. 0.24.0).

@tomchristie
Copy link
Member

Ug. This wasn't even in the 0.23.2 CHANGELOG. 😣

Yes let's pull it and release a 0.23.3.
I think it's a change that's worth consider, but I screwed up the release process by having let it creep into a minor release.

@tomchristie tomchristie mentioned this pull request Jan 4, 2023
@tomchristie tomchristie requested a review from a team January 4, 2023 09:01
@tomchristie tomchristie marked this pull request as ready for review January 4, 2023 09:02
@tomchristie tomchristie merged commit bddd774 into master Jan 4, 2023
@tomchristie tomchristie deleted the revert-2523 branch January 4, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants