Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop window.open from hanging when prevented #29851

Merged
merged 2 commits into from Jun 24, 2021
Merged

fix: stop window.open from hanging when prevented #29851

merged 2 commits into from Jun 24, 2021

Conversation

nornagon
Copy link
Member

Description of Change

Fixes a never-ending sendSync when calling window.open with
nativeWindowOpen: false and the new window is denied.

Fixes #29509.

Checklist

Release Notes

Notes: Fixed a hang when denying a window.open using setWindowOpenHandler when nativeWindowOpen: false.

@nornagon nornagon requested a review from a team as a code owner June 22, 2021 20:21
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 22, 2021
@nornagon nornagon added semver/patch backwards-compatible bug fixes target/12-x-y labels Jun 22, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 23, 2021
@nornagon
Copy link
Member Author

CI failures are flakes; merging.

@nornagon nornagon merged commit 0f16575 into main Jun 24, 2021
@nornagon nornagon deleted the fix-window-open-hang branch June 24, 2021 15:50
@release-clerk
Copy link

release-clerk bot commented Jun 24, 2021

Release Notes Persisted

Fixed a hang when denying a window.open using setWindowOpenHandler when nativeWindowOpen: false.

This was referenced Jun 24, 2021
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jun 24, 2021

I have automatically backported this PR to "12-x-y", please check out #29881

@trop trop bot removed the target/12-x-y label Jun 24, 2021
@trop
Copy link
Contributor

trop bot commented Jun 24, 2021

I have automatically backported this PR to "13-x-y", please check out #29882

@trop
Copy link
Contributor

trop bot commented Jun 24, 2021

I have automatically backported this PR to "14-x-y", please check out #29883

@nornagon nornagon mentioned this pull request Jun 24, 2021
Closed
@jtbandes jtbandes mentioned this pull request Jul 2, 2021
Merged
BlackHole1 pushed a commit to BlackHole1/electron that referenced this pull request Aug 30, 2021
@nornagon @BlackHole1
fix: stop window.open from hanging when prevented (electron#29851)
728fb3f
@jtbandes jtbandes mentioned this pull request Jan 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: setWindowOpenHandler freeze when calling window.open('url')
3 participants
@nornagon @deepak1556 @codebytere