This repository has been archived by the owner on Mar 24, 2024. It is now read-only.
Upgrade electron & related packages #5102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbandes
commented
Jan 7, 2023
| @@ -141,11 +142,9 @@ function newStudioWindow(deepLinks: string[] = []): BrowserWindow { | |||
| }); | |||
|
|
|||
| // Open all new windows in an external browser | |||
| // Note: this API is supposed to be superseded by webContents.setWindowOpenHandler, | |||
| // but using that causes the app to freeze when a new window is opened. | |||
There was a problem hiding this comment.
this bug no longer seems to happen, probably fixed in electron/electron#29851 (#604 (comment))
defunctzombie
approved these changes
Jan 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Changes
None
Description