[Bug]: setWindowOpenHandler of webContents not called while new window open.

[patil-milind]

Preflight Checklist

I have read the Contributing Guidelines for this project.
I agree to follow the Code of Conduct that this project adheres to.
I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Electron Version

12.0.0

What operating system are you using?

Windows

Operating System Version

Windows 10

What arch are you using?

x64

Last Known Working Electron version

12.0.0

Expected Behavior

Electron version: 12.0.0
Problem: Need to disable new windows popup, for this use the event and its working but this is deprecated in Electron 12.0

win.webContents.on('new-window'', event => {
    event.preventDefault()
  })

So instead of above used the suggested alternative handler but this is not getting called during new windows open or mouse mid click.

win.webContents.setWindowOpenHandler(() => {
            return { action: 'deny' };
     });

Expected behavior: On mouse mid click new windows creation should prevented.

Actual Behavior

Actual : New window opens on mouse windows click.

Testcase Gist URL

No response

[VerteDinde]

Hey @patil-milind, thanks for reporting this issue! Correct me if I'm wrong, but I think you may be experiencing the same issue as this user: #27967 We have a fix for this merged into master, and will backport it into 12-x-y - the fix is already available in the newest 13 beta. I'll close this issue once it's backported into 12.

[patil-milind]

@VerteDinde Yes its same issue as #27967 .

[nornagon]

Duplicate of #27967

[VerteDinde]

@patil-milind This fix is available in 12.0.5 🙂 Let us know if it still doesn't work for you!

[Delagen]

@VerteDinde I catch download window with this, and calling {action:'deny'} freeze main frame

[nvdai2401]

catch download window with this, and calling {action:'deny'} freeze main frame

I'm dealing with the same problem as you

[andresavic]

I get the error message
this.win.webContents.setWindowOpenHandler(({ url }) => { return { action: 'deny' } })

The window open handler response must be an object, but was instead of type 'undefined'.

and the main window freezes as well.

[nornagon]

@andresavic @nvdai2401 @Delagen that sounds like #29509, which is recently fixed by #29851.