This repository has been archived by the owner on Mar 24, 2024. It is now read-only.
Register studio as a url handler for foxglove:// files #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhurliman
reviewed
Apr 16, 2021
jhurliman
reviewed
Apr 16, 2021
Add an "open" command with support for rosbag files from urls
defunctzombie
force-pushed
the
roman/fg-364-foxglove-url-handler
branch
from
155cba2
to
77377b4
Compare
jtbandes
reviewed
Jul 2, 2021
Comment on lines
+83
to
+84
| // Note: this API is supposed to be superseded by webContents.setWindowOpenHandler, | ||
| // but using that causes the app to freeze when a new window is opened. |
There was a problem hiding this comment.
I think this is fixed by electron/electron#29851
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for foxglove:// urls and
File -> New Window.foxglove://url support provides a way for hyperlinks links to invoke actions into the studio app. Such actions could include features like loading a bag file and jumping to a particular time, loading specific layouts, etc.The first supported link is
foxglove://open?type=rosbag&url=http://.... Clicking the link will inform studio to open the remote bag file.Here is what a link to our demo bag would look like.
foxglove://open?type=rosbag&url=https://storage.googleapis.com/foxglove-public-assets/demo.bag