fix: ensure ready-to-show event is fired #25448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
reviewed
Sep 14, 2020
|
It seems that when loading |
codebytere
approved these changes
Sep 15, 2020
|
Release Notes Persisted
|
|
I was unable to backport this PR to "10-x-y" cleanly; |
|
I have automatically backported this PR to "11-x-y", please check out #25471 |
|
I was unable to backport this PR to "9-x-y" cleanly; |
|
I was unable to backport this PR to "8-x-y" cleanly; |
mlaurencin
pushed a commit
to mlaurencin/electron
that referenced
this pull request
Sep 16, 2020
* fix: ensure ready-to-show event is fired * test: acutally draw something when capturePage
3 tasks
CezaryKulakowski
added a commit
to CezaryKulakowski/electron
that referenced
this pull request
Sep 25, 2020
This reverts commit e5933c6.
4 tasks
trop bot
pushed a commit
that referenced
this pull request
Sep 28, 2020
This reverts commit e5933c6.
3 tasks
miniak
pushed a commit
that referenced
this pull request
Oct 23, 2020
ckerr
pushed a commit
that referenced
this pull request
Oct 24, 2020
vladimiry
added a commit
to vladimiry/ElectronMail
that referenced
this pull request
Nov 2, 2020
* some time ago @electron made "ready-to-show" event to be fired multiple times which goes against their documentation (possibly caused by electron/electron#25448) and so was causing the annoying windows flickering in the app
devDefiWeb
added a commit
to devDefiWeb/electron-mail-app
that referenced
this pull request
May 28, 2022
* some time ago @electron made "ready-to-show" event to be fired multiple times which goes against their documentation (possibly caused by electron/electron#25448) and so was causing the annoying windows flickering in the app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Close #25253.
The
ready-to-showevent is not very stable that, sometimes on some machines it might not be fired, and the actual behavior depends on the version of Chromium.To work around this bug, we ensure the
ready-to-showevent is emitted if it has not been emitted afterdid-finish-loadevent.The real fix should be fixing the event itself, but unfortunately we haven't been able to find out why it did not emit so far, you can check #7779 on the history of this bug.
Checklist
npm testpassesRelease Notes
Notes: Fix
ready-to-showevent not emitted on some machines.