Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure ready-to-show event is fired #26140

Merged
merged 1 commit into from Oct 24, 2020
Merged

fix: ensure ready-to-show event is fired #26140

merged 1 commit into from Oct 24, 2020

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Oct 23, 2020 •
edited

Backport of #25448

See that PR for details.

Notes: Fix ready-to-show event not emitted on some machines.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 23, 2020
@trop trop bot mentioned this pull request Oct 23, 2020
Merged
6 tasks
@trop trop bot added 8-x-y backport This is a backport PR labels Oct 23, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 23, 2020
@miniak miniak force-pushed the miniak/ready-to-show-ensure-8-x-y branch from 17ed33f to 5221646 Compare October 23, 2020 22:36
@ckerr ckerr merged commit c865244 into 8-x-y Oct 24, 2020
@release-clerk
Copy link

release-clerk bot commented Oct 24, 2020

Release Notes Persisted

Fix ready-to-show event not emitted on some machines.

@ckerr ckerr deleted the miniak/ready-to-show-ensure-8-x-y branch October 24, 2020 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
8-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniak @codebytere @ckerr