fix: ensure ready-to-show event is fired #25490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
zcbenz
approved these changes
Sep 17, 2020
|
Release Notes Persisted
|
zcbenz
deleted the
trop/9-x-y-bp-fix-ensure-ready-to-show-event-is-fired-1600264751290
branch
|
I really need this for v9.x but it seems like an update hasn't been released yet. When would it be available? |
miniak
pushed a commit
that referenced
this pull request
Oct 23, 2020
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #25448
See that PR for details.
Notes: Fix
ready-to-showevent not emitted on some machines.