fix: ensure ready-to-show event is fired

[CezaryKulakowski]

Description of Change

When this chromium change landed:
https://chromium-review.googlesource.com/c/chromium/src/+/2215143
event ready-to-show is not always emitted. This pull request removes following workaround for the problem:
#25448
and fixes the problem the way which ensures that event is emitted exactly at the same moment it would be emitted before problematic chromium change landed. Previous fix was not ideal as with it event ready-to-show is emitted only after did-finish-load was received what significantly delays moment the window is displayed (also: it may happen that did-finish-load is never emitted for certain pages).

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• PR title follows semantic commit guidelines
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fix ready-to-show event not emitted on some machines.

[release-clerk]

Release Notes Persisted

Fix ready-to-show event not emitted on some machines.

[trop]

I was unable to backport this PR to "10-x-y" cleanly;
you will need to perform this backport manually.

[trop]

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

[trop]

I have automatically backported this PR to "11-x-y", please check out #25672

[trop]

@codebytere has manually backported this PR to "10-x-y", please check out #25932

[trop]

@codebytere has manually backported this PR to "9-x-y", please check out #25933

[pushkin-]

@CezaryKulakowski Which version of 11 did this land in? 11.0.0? I'm not seeing this in the release notes, only the notes for this PR.

And I have case where ready-to-show isn't firing when I load a page into a BrowserView in the BrowserWindow, but don't load a page in the BrowserWindow itself. Is this what the bug is fixing, or no?

actually, it fires on my machine, but not on others when loading specific pages in the BrowserView (possibly pages that are load balanced)

Maybe OnFirstNonEmptyLayout isn't running?

[pushkin-]

@CezaryKulakowski @codebytere this PR seems to have re-introduced this issue

[killghost]

This bug still exists in electron 13, when can it be fixed? grateful