Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): bump rubocop from 1.22.1 to 1.22.2 #2546

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 22, 2021

Bumps rubocop from 1.22.1 to 1.22.2.

Release notes

Sourced from rubocop's releases.

RuboCop 1.22.2

Bug fixes

  • #10165: Fix Layout/DotPosition false positives when the selector and receiver are on the same line. (@​dvandersluis)
  • #10171: Fix Style/HashTransformKeys and Style/HashTransformValues incorrect auto-correction when inside block body. (@​franzliedke)
  • #10180: Fix an error for Style/SelectByRegexp when using match? without a receiver. (@​koic)
  • #10193: Fix an error for Layout/EmptyLinesAroundExceptionHandlingKeywords when begin and rescue are on the same line. (@​koic)
  • #10185: Fix a false positive for Lint/AmbiguousRange when using self in a range literal. (@​koic)
  • #10200: Fix an error when inspecting a directory named *. (@​koic)
  • #10149: Fix Bundler/GemComment where it would not detect an offense in some cases when OnlyFor is set to restrictive_version_specifiers. (@​Drowze)

Changes

Changelog

Sourced from rubocop's changelog.

1.22.2 (2021-10-22)

Bug fixes

  • #10165: Fix Layout/DotPosition false positives when the selector and receiver are on the same line. ([@​dvandersluis][])
  • #10171: Fix Style/HashTransformKeys and Style/HashTransformValues incorrect auto-correction when inside block body. ([@​franzliedke][])
  • #10180: Fix an error for Style/SelectByRegexp when using match? without a receiver. ([@​koic][])
  • #10193: Fix an error for Layout/EmptyLinesAroundExceptionHandlingKeywords when begin and rescue are on the same line. ([@​koic][])
  • #10185: Fix a false positive for Lint/AmbiguousRange when using self in a range literal. ([@​koic][])
  • #10200: Fix an error when inspecting a directory named *. ([@​koic][])
  • #10149: Fix Bundler/GemComment where it would not detect an offense in some cases when OnlyFor is set to restrictive_version_specifiers. ([@​Drowze][])

Changes

  • #10157: Updated Gemspec/RequiredRubyVersion handle being set to blank values. ([@​dvandersluis][])
  • #10176: Unmark AutoCorrect: false from Security/JSONLoad. ([@​koic][])
  • #10186: Explicit block arg is not counted for Metrics/ParameterLists. ([@​koic][])
Commits
  • 60484a7 Cut 1.22.2
  • cc7ac48 Update Changelog
  • 1d5621d Suppress warning: constant Net::HTTPServerException is deprecated
  • a319d09 Updated Gemspec/RequiredRubyVersion register an offense when set to blank v...
  • 34ce2ed [Fix #10200] Fix an error when inspecting a directory named *
  • 5b27789 [Fix #10186] Explicit block arg is not counted for Metrics/ParameterLists
  • 1894717 Merge pull request #10193 from koic/fix_an_error_for_empty_lines_around_excep...
  • 95262d0 Fix an error for Layout/EmptyLinesAroundExceptionHandlingKeywords
  • 41f2632 Merge pull request #10187 from koic/fix_false_positive_for_lint_ambiguous_range
  • 96457ee [Fix #10185] Fix a false positive for Lint/AmbiguousRange
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.22.1 to 1.22.2.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.22.1...v1.22.2)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Oct 22, 2021
@tjvman
Copy link
Member

tjvman commented Oct 25, 2021

It seems like Rubocop's attempt to fix rubocop/rubocop#10165 introduced a bunch of false positives. It looks like it's flagging multi-line do/end blocks, curly brace-delimited structures, and paren-delimited structures that have a method call after the closing symbol.

Only way I've been able to get it to not complain is to make the structures one line, which is not a viable solution.

We can't merge this PR. Need to wait for Rubocop to fix this new problem or disable the Layout/DotPosition cop.

@tjvman tjvman closed this Oct 25, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 25, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/bundler/rubocop-1.22.2 branch October 25, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants