Updated Gemspec/RequiredRubyVersion to handle blank values
#10157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Oct 2, 2021
dvandersluis
force-pushed
the
gemspec/required-ruby-version
branch
from
025639f
to
f95b7d9
Compare
koic
reviewed
Oct 2, 2021
dvandersluis
force-pushed
the
gemspec/required-ruby-version
branch
from
f95b7d9
to
982ac0d
Compare
|
I've updated this to just keep the added version checks (for |
dvandersluis
force-pushed
the
gemspec/required-ruby-version
branch
from
982ac0d
to
41b59f8
Compare
dvandersluis
changed the title
Gemspec/RequiredRubyVersion to detect more issuesGemspec/RequiredRubyVersion to handle blank values
|
@koic are you ok with merging this in its current form? |
|
Looks good to me. Thanks! |
8 tasks
nickpellant
added a commit
to nickpellant/rubocop
that referenced
this pull request
Jan 11, 2022
Fixes a bug believed to be introduced by rubocop#10157 where the cop no longer supported multiple requirements when they were passed as a `Gem::Requirement` object instead of as an array.
bbatsov
pushed a commit
that referenced
this pull request
Jan 12, 2022
Fixes a bug believed to be introduced by #10157 where the cop no longer supported multiple requirements when they were passed as a `Gem::Requirement` object instead of as an array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds detection for empty versions and
required_ruby_versionbeing set more than once. Also did a minor refactor to useon_sendinstead of having all the logic inon_new_investigation.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.