Fix Bundler/GemComment offense detection with restrictive_version_specifiers #10149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
GemComment
'sOnlyFor
option was set torestrictive_version_specifiers
, the cop would not detect an offense where it should if either:=
operator or no operator at all)This PR aims to fix both problems above, while also adding tests for it.
obs.: It's Hacktoberfest already! Can we have the "hacktoberfest" topic added to Rubocop repository, so pull requests may count towards the event? (as Hacktoberfest is an opt-in event since last year)
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.