Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bundler/GemComment offense detection with restrictive_version_specifiers #10149

Merged
merged 1 commit into from Oct 7, 2021

Conversation

Drowze
Copy link
Contributor

@Drowze Drowze commented Oct 1, 2021

If GemComment's OnlyFor option was set to restrictive_version_specifiers, the cop would not detect an offense where it should if either:

  • there was a leading space on the restrictive version argument
  • the version was frozen (either by using an = operator or no operator at all)

This PR aims to fix both problems above, while also adding tests for it.

obs.: It's Hacktoberfest already! Can we have the "hacktoberfest" topic added to Rubocop repository, so pull requests may count towards the event? (as Hacktoberfest is an opt-in event since last year)


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@Drowze Drowze changed the title Fix Bundler/GemComment offensense detection with restrictive_version_specifiers Fix Bundler/GemComment offense detection with restrictive_version_specifiers Oct 1, 2021
@koic
Copy link
Member

koic commented Oct 1, 2021

obs.: It's Hacktoberfest already! Can we have the "hacktoberfest" topic added to Rubocop repository, so pull requests may count towards the event? (as Hacktoberfest is an opt-in event since last year)

Done!

If GemComment OnlyFor option was set to restrictive_version_specifiers,
the cop would not detect an offense if either:
- there was a leading space on the restrictive version argument
- the version was frozen
@Drowze Drowze requested a review from koic October 5, 2021 08:34
@koic koic merged commit 589c6e8 into rubocop:master Oct 7, 2021
@koic
Copy link
Member

koic commented Oct 7, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants