Unmark AutoCorrect: false from Security/JSONLoad
#10176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvandersluis
reviewed
Oct 8, 2021
| @@ -7,7 +7,7 @@ module Security | |||
| # security issues. | |||
| # | |||
| # @safety | |||
| # Autocorrect is disabled by default because it's potentially dangerous. | |||
| # This cop is unsafe autocorrection because it's potentially dangerous. | |||
There was a problem hiding this comment.
Suggested change
| # This cop is unsafe autocorrection because it's potentially dangerous. | |
| # This cop's autocorrection is unsafe because it's potentially dangerous. |
dvandersluis
approved these changes
Oct 8, 2021
This `AutoCorrect: false` looks like it was set when there was no way to safe autocorrect by `SafeAutocorrect: false`. rubocop#3584 Test code for `Security/JSONLoad`'s autocorrection exists. So it can be enabled by default. However, it is still unsafe because `SafeAutocorrect: false`.
koic
force-pushed
the
unmark_autocorrect_false_from_security_json_load
branch
from
1be3793
to
8c9692b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
AutoCorrect: falselooks like it was set when there was no way to safe autocorrect bySafeAutocorrect: false.#3584
Test code for
Security/JSONLoad's autocorrection exists. So it can be enabled by default. However, it is still unsafe becauseSafeAutocorrect: false.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.