New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps(maven): bump netty-bom from 4.1.69.Final to 4.1.70.Final #8131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [netty-bom](https://github.com/netty/netty) from 4.1.69.Final to 4.1.70.Final. - [Release notes](https://github.com/netty/netty/releases) - [Commits](netty/netty@netty-4.1.69.Final...netty-4.1.70.Final) --- updated-dependencies: - dependency-name: io.netty:netty-bom dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
@korthout could you take a look at it? It looks like some of the things were moved to a new dependency, so I guess we just need to add that to ours. Nothing urgent, but would be cool to close sometime next week. |
netty-bom 4.1.70 contains the changes from pull request netty/netty#11798, which moved the classes out of the native modules to make sure the same classes don't end up on the classpath multiple times. For us it means that we need to depend on both the native and classes modules. However, since we don't use the native module directly (only classes that were moved to this classes module), we need to force the dependency plugin to consider the native module as used.
korthout
force-pushed
the
dependabot/maven/io.netty-netty-bom-4.1.70.Final
branch
from
November 11, 2021 12:23
e51c738
to
f00a4d3
Compare
npepinpe
approved these changes
Nov 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
👍 thanks Nico!
Build succeeded: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps netty-bom from 4.1.69.Final to 4.1.70.Final.
Commits
f49c94c
[maven-release-plugin] prepare release netty-4.1.70.Final30d9404
Make static final buffers unreleasable and read-only (#11802)d6f029c
Update java versions to latest update (#11812)2a028dd
Fix gzip decoding when FLG.FHCRC is set (#11805)baba1f4
Fail build if netty-all pulls in duplicated classes (#11804)555fcf2
Add unit test that verifies we not fail hostname verification if a matching S...6a84af7
Move java classes out of the native modules (#11798)658de70
Update Groovy versions (#11800)3a1fb3f
Fix the javadoc for ByteBuf.setCharSequence (#11793)e1d2a95
Exclude transitive dependencies of rarely used modules from netty-all (#11786)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)