New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail build if netty-all pulls in duplicated classes #11804
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We should fail the build if netty-all pulls in dependencies that produce duplicated classes on the classpath Modifications: Add maven plugin to verify we not have duplicated classes on the classpath / dependencies Result: Related to #11791
To test this I added some extra dependency that would cause the duplicated classes issue. The build fails with:
|
chrisvest
approved these changes
Oct 28, 2021
chrisvest
approved these changes
Oct 28, 2021
normanmaurer
added a commit
that referenced
this pull request
Oct 28, 2021
Motivation: We should fail the build if netty-all pulls in dependencies that produce duplicated classes on the classpath Modifications: Add maven plugin to verify we not have duplicated classes on the classpath / dependencies Result: Related to #11791
laosijikaichele
pushed a commit
to laosijikaichele/netty
that referenced
this pull request
Dec 16, 2021
Motivation: We should fail the build if netty-all pulls in dependencies that produce duplicated classes on the classpath Modifications: Add maven plugin to verify we not have duplicated classes on the classpath / dependencies Result: Related to netty#11791
laosijikaichele
pushed a commit
to laosijikaichele/netty
that referenced
this pull request
Dec 16, 2021
Motivation: We should fail the build if netty-all pulls in dependencies that produce duplicated classes on the classpath Modifications: Add maven plugin to verify we not have duplicated classes on the classpath / dependencies Result: Related to netty#11791
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
Motivation: We should fail the build if netty-all pulls in dependencies that produce duplicated classes on the classpath Modifications: Add maven plugin to verify we not have duplicated classes on the classpath / dependencies Result: Related to netty#11791
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We should fail the build if netty-all pulls in dependencies that produce duplicated classes on the classpath
Modifications:
Add maven plugin to verify we not have duplicated classes on the classpath / dependencies
Result:
Related to #11791