Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude transitive dependencies of rarely used modules from netty-all #11786

Merged
merged 1 commit into from Oct 25, 2021

Conversation

chrisvest
Copy link
Contributor

Motivation:
Netty-all is used to unconditionally pull in all netty modules with the same version.
Some of these modules have dependencies themselves that are pulled in transitively, yet they are rarely used.

Modification:
Exclude the transitive dependencies of netty-codec-xml, netty-transport-rxtx, and netty-transport-udt.

Those who wish to restore these modules to working order can additionally depend on org.fasterxml:aalto-xml, org.rxtx:rxtx, or com.barchart.udt:barchart-udt-bundle, respectively.

Result:
Depending on netty-all no longer transitively depends on any non-netty maven modules.

Motivation:
Netty-all is used to unconditionally pull in all netty modules with the same version.
Some of these modules have dependencies themselves that are pulled in transitively, yet they are rarely used.

Modification:
Exclude the transitive dependencies of netty-codec-xml, netty-transport-rxtx, and netty-transport-udt.

Those who wish to restore these modules to working order can additionally depend on org.fasterxml:aalto-xml, org.rxtx:rxtx, or com.barchart.udt:barchart-udt-bundle, respectively.

Result:
Depending on netty-all no longer transitively depends on any non-netty maven modules.
@chrisvest chrisvest added this to the 4.1.70.Final milestone Oct 22, 2021
@normanmaurer
Copy link
Member

This looks good to me!

@normanmaurer normanmaurer merged commit e1d2a95 into netty:4.1 Oct 25, 2021
normanmaurer pushed a commit that referenced this pull request Oct 25, 2021
…#11786)

Motivation:
Netty-all is used to unconditionally pull in all netty modules with the same version.
Some of these modules have dependencies themselves that are pulled in transitively, yet they are rarely used.

Modification:
Exclude the transitive dependencies of netty-codec-xml, netty-transport-rxtx, and netty-transport-udt.

Those who wish to restore these modules to working order can additionally depend on org.fasterxml:aalto-xml, org.rxtx:rxtx, or com.barchart.udt:barchart-udt-bundle, respectively.

Result:
Depending on netty-all no longer transitively depends on any non-netty maven modules.
@chrisvest chrisvest deleted the 41-netty-all-exclude-extras branch October 26, 2021 08:25
laosijikaichele pushed a commit to laosijikaichele/netty that referenced this pull request Dec 16, 2021
…netty#11786)

Motivation:
Netty-all is used to unconditionally pull in all netty modules with the same version.
Some of these modules have dependencies themselves that are pulled in transitively, yet they are rarely used.

Modification:
Exclude the transitive dependencies of netty-codec-xml, netty-transport-rxtx, and netty-transport-udt.

Those who wish to restore these modules to working order can additionally depend on org.fasterxml:aalto-xml, org.rxtx:rxtx, or com.barchart.udt:barchart-udt-bundle, respectively.

Result:
Depending on netty-all no longer transitively depends on any non-netty maven modules.
laosijikaichele pushed a commit to laosijikaichele/netty that referenced this pull request Dec 16, 2021
…netty#11786)

Motivation:
Netty-all is used to unconditionally pull in all netty modules with the same version.
Some of these modules have dependencies themselves that are pulled in transitively, yet they are rarely used.

Modification:
Exclude the transitive dependencies of netty-codec-xml, netty-transport-rxtx, and netty-transport-udt.

Those who wish to restore these modules to working order can additionally depend on org.fasterxml:aalto-xml, org.rxtx:rxtx, or com.barchart.udt:barchart-udt-bundle, respectively.

Result:
Depending on netty-all no longer transitively depends on any non-netty maven modules.
raidyue pushed a commit to raidyue/netty that referenced this pull request Jul 8, 2022
…netty#11786)

Motivation:
Netty-all is used to unconditionally pull in all netty modules with the same version.
Some of these modules have dependencies themselves that are pulled in transitively, yet they are rarely used.

Modification:
Exclude the transitive dependencies of netty-codec-xml, netty-transport-rxtx, and netty-transport-udt.

Those who wish to restore these modules to working order can additionally depend on org.fasterxml:aalto-xml, org.rxtx:rxtx, or com.barchart.udt:barchart-udt-bundle, respectively.

Result:
Depending on netty-all no longer transitively depends on any non-netty maven modules.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants