Move java classes out of the native modules #11798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisvest
approved these changes
Oct 26, 2021
|
You also need to tell japicmp that this is fine, though. |
Motivation: To ensure the user doesnt end up with the same classes multiple times in the classpath when including native dependencies for different platforms we need to ensure we not include the java classes in this jars but provide them as seperate modules. Modifications: - Introduces a *-classes-* module for each *-native-* module and depend on it from the native module - Add entries to the bom - Depend on the correct artifacts in netty-all to ensure we not end up with the same classes multiple times Result: Fixes #11791
normanmaurer
force-pushed
the
duplicate_classes_v2
branch
from
59422d0
to
29f8bcc
Compare
chrisvest
approved these changes
Oct 26, 2021
NiteshKant
approved these changes
Oct 26, 2021
trustin
reviewed
Oct 27, 2021
| --> | ||
| <dependency> | ||
| <groupId>${project.groupId}</groupId> | ||
| <artifactId>netty-transport-native-epoll</artifactId> | ||
| <artifactId>netty-transport-classes-epoll</artifactId> |
There was a problem hiding this comment.
Not sure if the name classes makes sense although I don't have a good idea on this. Maybe common? 🤔
There was a problem hiding this comment.
I picked classes as it contains the classes but no idea 🤷♂️
There was a problem hiding this comment.
or just nothing? netty-transport-epoll
There was a problem hiding this comment.
Forgot to add don't to have a good idea 😅
There was a problem hiding this comment.
Either nothing or classes seem fine to me.
There was a problem hiding this comment.
Thinking about it, I think I have a slight preference for keeping it. Without, it might be the first dependency people add, only to discover it doesn’t work because the native binaries are missing.
There was a problem hiding this comment.
Thinking about it, I think I have a slight preference for keeping it. Without, it might be the first dependency people add, only to discover it doesn’t work because the native binaries are missing.
@trustin works for you ?
|
Let me merge this one so we can make progress. |
|
@normanmaurer Is it intended to have netty-transport-native-unix-common-4.1.70.Final.jar with class files? Or are they different from the ones you moved here? (jar size of 4.1.69 similar) |
|
yes this is not a problem |
korthout
added a commit
to camunda/zeebe
that referenced
this pull request
Nov 11, 2021
netty-bom 4.1.70 contains the changes from pull request netty/netty#11798, which moved the classes out of the native modules to make sure the same classes don't end up on the classpath multiple times. For us it should mean that we don't have to depend on the specific native module any more but can simply depend on the common/shared classes module.
korthout
added a commit
to camunda/zeebe
that referenced
this pull request
Nov 11, 2021
netty-bom 4.1.70 contains the changes from pull request netty/netty#11798, which moved the classes out of the native modules to make sure the same classes don't end up on the classpath multiple times. For us it means that we need to depend on both the native and classes modules. However, since we don't use the native module directly (only classes that were moved to this classes module), we need to force the dependency plugin to consider the native module as used.
laosijikaichele
pushed a commit
to laosijikaichele/netty
that referenced
this pull request
Dec 16, 2021
Motivation: To ensure the user doesnt end up with the same classes multiple times in the classpath when including native dependencies for different platforms we need to ensure we not include the java classes in this jars but provide them as seperate modules. Modifications: - Introduces a *-classes-* module for each *-native-* module and depend on it from the native module - Add entries to the bom - Depend on the correct artifacts in netty-all to ensure we not end up with the same classes multiple times Result: Fixes netty#11791
laosijikaichele
pushed a commit
to laosijikaichele/netty
that referenced
this pull request
Dec 16, 2021
Motivation: To ensure the user doesnt end up with the same classes multiple times in the classpath when including native dependencies for different platforms we need to ensure we not include the java classes in this jars but provide them as seperate modules. Modifications: - Introduces a *-classes-* module for each *-native-* module and depend on it from the native module - Add entries to the bom - Depend on the correct artifacts in netty-all to ensure we not end up with the same classes multiple times Result: Fixes netty#11791
This was referenced Dec 20, 2021
npepinpe
pushed a commit
to camunda/zeebe
that referenced
this pull request
Jan 15, 2022
netty-bom 4.1.70 contains the changes from pull request netty/netty#11798, which moved the classes out of the native modules to make sure the same classes don't end up on the classpath multiple times. For us it means that we need to depend on both the native and classes modules. However, since we don't use the native module directly (only classes that were moved to this classes module), we need to force the dependency plugin to consider the native module as used.
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
Motivation: To ensure the user doesnt end up with the same classes multiple times in the classpath when including native dependencies for different platforms we need to ensure we not include the java classes in this jars but provide them as seperate modules. Modifications: - Introduces a *-classes-* module for each *-native-* module and depend on it from the native module - Add entries to the bom - Depend on the correct artifacts in netty-all to ensure we not end up with the same classes multiple times Result: Fixes netty#11791
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
To ensure the user doesnt end up with the same classes multiple times in the classpath when including native dependencies for different platforms we need to ensure we not include the java classes in this jars but provide them as separate modules.
Modifications:
Result:
Fixes #11791