Upgrade to electron 9.3.5 #21777

sadick254 · 2020-12-01T17:42:33Z

This upgrades atom from 6.1.12 to 9.3.5

TODO

Issues to resolve

Failure due to node-abi not detecting abi for version 9.3.5 and runtime electron

Failing tests

Regressions to fix before merging

Known bugs resolved by this upgrade

Electron Upgrade Test Manifest

Review issues tagged with electron to see if any of them are fixed
Verify that you can collaborate with Teletype
- Host using Atom's current stable release can collaborate with guest using Atom with the new version of Electron
- Guest using Atom's current stable release can collaborate with host using Atom with the new version of Electron
- Host and guest can collaborate when both are using Atom with the new version of Electron
Steps
1. Open a file
2. Share a portal
3. Have a guest join the portal
4. When guest edits the text in the file, verify that the host sees those changes

Check for regressions experienced in previous upgrades

Text Input/Keybindings

See how to setup keyboard layouts.

IME not working (1.19.0-beta2: Cursor stucks at the first letter when using macOS Chinese IME #14911)
- macOS
- Windows 10
- Ubuntu
Repro steps
1. Install an IME layout, for example Pinyin simplified
2. Open Atom and use the layout you installed as the keyboard layout
3. Example, if you picked Pinyin simplified type in zhongwenshuru
Expected: in Pinyin simplified 中文输入 is expected

Issues we've seen: Only shows latin first character and not every character typed.
macOS: Key binding with composition characters are ignored (key-mappings with alt don't suppress Mac OS composition characters anymore (atom-1.19) #15189)
Repro steps
1. Open your keymap.cson file and add the following:
```
'atom-text-editor':
  # use hjkl; vim-like when pressing alt (word by word, paragraph by paragraph)
  # or alt (letter by letter)
  'alt-h': 'core:move-left'
  'alt-j': 'core:move-down'
  'alt-k': 'core:move-up'
  'alt-l': 'core:move-right'
```
2. Save keymap.cson and reload atom.
3. Try the new keymappings under ABC - Extended keyboard layout
Expected: the keybindings work

Issues we've seen: it types out the modified keys and ignores the key mapping
macOS: Composition characters mess up insertion point (Composition characters mess up insertion point #15344)
Repro steps
1. Open keymap.cson and add the following:
```
'atom-text-editor':
  'alt-n': 'core:move-down'
  'alt-o': 'core:move-down'
```
2. Have the following in your buffer:
```
Foo
Bar
```
3. Have the cursor at the beginning of file(before F character) Type alt-n, then arrow right, then insert a character. Observe that the character is inserted at the beginning of the line (where the alt-n left you).
4. Repeat steps using alt-o instead of alt-n.
Expected: Both alt-o and alt-n behave the same

Issues we've seen:
Ubuntu: Keystrokes involving ctrl resolve to the default layout instead of the active layout (Keystrokes involving ctrl on Linux resolve to the default layout instead of the active layout #13170)
Repro steps

This should be tested on Linux with gnome
1. Install a Linux ditro with gnome, for example Ubuntu
2. Install French AZERTY and English US QWERTY layouts
3. Change the default layout to be French AZERTY
4. Open Atom and switch to English US QWERTY layout
5. Press ctrl-w
Expected: core:close to dispatch (Or the keybinding-resolver to resolve to ctrl-w). Should be resolving to the keyboard layout that is chosen and not the OS default layout.

Issues we've seen: core:undo dispatched because it was resolved as ctrl-z because AZERTY has Z where W is on QWERTY.
Other keyboard layouts on new Electron version
- macOS: ABC - Extended
- macOS: Slovak
- macOS: U.S. International
- macOS: Squirrel (https://github.com/rime/squirrel)
- macOS: Full-Width Alphanumeric (Google) - Japanese layout (https://www.google.co.jp/ime/)
- Windows: U.S.
- Linux: Pinyin Simplified

UI

Other

mfonville · 2020-12-02T08:59:02Z

As noted in #21422 (comment) and a reminder I had put here: atom-community#75 (comment)

If you are upgrading electron to a version of 7 or higher, you can drop thelibgconf-2-4 dependency in resources/linux/debian/control.in

aminya · 2020-12-06T10:41:35Z

For Windows, Superstring error is fixed by: atom/superstring#91

aminya · 2020-12-10T15:56:22Z

By the way, probably at some point, you will encounter some errors that say electron-link is not able to bundle the app because of lazy requires. You will need to register a new version for the electron-link. My last merged PR is still awaiting registration.

https://github.com/atom/electron-link

which I think it would be better to merge atom/electron-link#31 before registration, as it tests electron-link for electron 9.

sadick254 · 2020-12-10T15:57:56Z

@aminya Noted. I will look into it.

aminya · 2020-12-10T16:43:09Z

By the way, probably at some point, you will encounter some errors that say electron-link is not able to bundle the app because of lazy requires. You will need to register a new version for the electron-link. My last merged PR is still awaiting registration.

https://github.com/atom/electron-link

which I think it would be better to merge atom/electron-link#31 before registration, as it tests electron-link for electron 9.

I believe that the current error in the CI is the error that I am talking about.

Assigning a deferred module to a variable that was not declared in this scope is not supported!

This commit fixes that error:
atom/electron-link@bb32af3#diff-078c9280de7dec39154b2c81504ea9fffc9a241dfa6654f82688c09794fa1c65

sadick254 · 2020-12-10T18:02:46Z

@aminya Am afraid the error on the CI is not the one you are talking about. I have however published a new release for electron-link and included it on this PR. The build is throwing an error while dumping symbols.

mfonville · 2020-12-10T21:35:17Z

I notice btw that in the bootstrap phase (at least on Linux) Python is on 2.7; shouldn't it be already be Python3 with these higher electron/apm/nmp versions?

aminya · 2020-12-10T21:39:55Z

I Am afraid the error on the CI is not the one you are talking about. I have however published a new release for electron-link and included it on this PR. The build is throwing an error while dumping symbols.

@sadick254 It was throwing the error on Windows. It is now gone. Windows does not have the minidump issue, and that's why it is ahead of other operating systems in the build script.

On Windows, less-node is throwing warnings/errors.

##[warning] The reference to the module is replaced with the lazy function, but it is assigned to "module" or "exports". In some cases the bundle might not work, which you should fix manually:
D:\a\1\s\out\app\node_modules\less\lib\less-node\fs.js

Probably my Less 3 PR will fix that:
atom/less-cache#17

aminya · 2020-12-10T23:14:16Z

Minidump error on Linux and MacOS will be probably fixed by #21792

mfonville · 2020-12-14T19:27:07Z

Electron 9.4.0 is now also available with some (security) fixes

aminya · 2020-12-16T03:45:31Z

The current failure in Windows CI is because of the "debug" module in spellcheck package. I have opened an issue for it.

atom/spell-check#356

aminya · 2020-12-16T18:42:12Z

fswin issue in Linux/MacOS is because of winattr which is used in text-buffer. I made a PR which probably fixes it.
atom/text-buffer#336

aminya · 2020-12-16T20:09:05Z

Running the build locally on Windwos fails because of the old superstring which is because of the old whats-my-line in github package.

@sadick254 This commit is incomplete. You should also bump the version in package-dependencies
c9524e9

-	"github": "0.36.3",
+   "github": "0.36.6",

spell-check commit is also incomplete.
21766a3

-    "spell-check": "0.76.2",
+   "spell-check": "0.77.0",

aminya · 2020-12-16T20:32:21Z

Windows build in PR CI finished. However, one of the core main tests time-outs:

##[error] The 'core-main-process' test step finished with a non-zero exit code 
 You can run the test again using: 
	 D:/a/1/s/out/Atom Dev x64/atom-dev.exe --resource-path D:\a\1\s --test --main-process D:\a\1\s\spec\main-process

 1) AtomWindow
       creating a real window
         creates a real, properly configured BrowserWindow:
     Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (D:\a\1\s\spec\main-process\atom-window.test.js)
      at listOnTimeout (internal/timers.js:531:17)
      at processTimers (internal/timers.js:475:7)

I built Atom locally after applying the changes of this comment.
However, Atom Window does not open. The process exists in the task manager, which I had to kill manually.

Also, Production CI fails to sign the executable due to a connection issue. Is the link still valid?

aminya · 2020-12-16T21:12:40Z

Downgrading to electron 7.3.3 gives a working Atom. However, I get these warnings when I launch Atom in dev mode:

(node:32076) Electron: Loading non context-aware native modules in the renderer process is deprecated and will stop working at some point in the future, please see https://github.com/electron/electron/issues/18397 for more information

and when I closed Atom:

Attempting to call a function in a renderer window that has been closed or released.
Function provided here: Object.<anonymous> (C:\Users\aminy\Documents\GitHub\JavaScript\@atom-ide-community\atom\node_modules\github\lib\worker.js:60:22
Remote event names: crashed, destroyed

Also, opening a project doesn't work.

aminya · 2020-12-16T22:00:12Z

app.allowRendererProcessReuse shuold be set to false in Electron 9, so we can keep using non-contet aware native modules.

Trying Electron 8.5.5 gives better warning messages about these native modules that should be updated. Pretty much all non N-api packages. If using NAN we should apply these changes like this: atom/node-keytar#182

This should be done before Electron 12 based on electron/electron#18397

❯ (electron) The default value of app.allowRendererProcessReuse is deprecated, it is currently "false".  It will change to be "true" in Electron 9.  For more information please check https://github.com/electron/electron/issues/18397
(node:31924) Electron: Loading non-context-aware native module in renderer: '\\?\C:\atom\out\Atom Dev x64\resources\app.asar.unpacked\node_modules\scrollbar-style\build\Release\scrollbar-style-observer.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
(node:31924) Electron: Loading non-context-aware native module in renderer: '\\?\C:\atom\out\Atom Dev x64\resources\app.asar.unpacked\node_modules\text-buffer\node_modules\superstring\build\Release\superstring.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
(node:31924) Electron: Loading non-context-aware native module in renderer: '\\?\C:\atom\out\Atom Dev x64\resources\app.asar.unpacked\node_modules\pathwatcher\build\Release\pathwatcher.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
(node:31924) Electron: Loading non-context-aware native module in renderer: '\\?\C:\atom\out\Atom Dev x64\resources\app.asar.unpacked\node_modules\git-utils\build\Release\git.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
(node:31924) Electron: Loading non-context-aware native module in renderer: '\\?\C:\atom\out\Atom Dev x64\resources\app.asar.unpacked\node_modules\tree-sitter-json\build\Release\tree_sitter_json_binding.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
(node:31924) Electron: Loading non-context-aware native module in renderer: '\\?\C:\atom\out\Atom Dev x64\resources\app.asar.unpacked\node_modules\oniguruma\build\Release\onig_scanner.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
(node:31924) Electron: Loading non-context-aware native module in renderer: '\\?\C:\Users\aminy\Documents\GitHub\JavaScript\@atom\spell-check\node_modules\spellchecker\build\Release\spellchecker.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
(node:31924) Electron: Loading non-context-aware native module in renderer: '\\?\C:\Users\aminy\.atom\packages\Hydrogen\node_modules\zeromq\build\Release\zmq.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
(node:31924) Electron: Loading non-context-aware native module in renderer: '\\?\C:\atom\out\Atom Dev x64\resources\app.asar.unpacked\node_modules\tree-sitter-c\build\Release\tree_sitter_c_binding.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
(node:31924) Electron: Loading non-context-aware native module in renderer: '\\?\C:\atom\out\Atom Dev x64\resources\app.asar.unpacked\node_modules\tree-sitter-cpp\build\Release\tree_sitter_cpp_binding.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
(node:31924) Electron: Loading non-context-aware native module in renderer: '\\?\C:\atom\out\Atom Dev x64\resources\app.asar.unpacked\node_modules\tree-sitter-css\build\Release\tree_sitter_css_binding.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
(node:31924) Electron: Loading non-context-aware native module in renderer: '\\?\C:\atom\out\Atom Dev x64\resources\app.asar.unpacked\node_modules\tree-sitter-go\build\Release\tree_sitter_go_binding.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
(node:31924) Electron: Loading non-context-aware native module in renderer: '\\?\C:\atom\out\Atom Dev x64\resources\app.asar.unpacked\node_modules\tree-sitter-embedded-template\build\Release\tree_sitter_embedded_template_binding.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
(node:31924) Electron: Loading non-context-aware native module in renderer: '\\?\C:\atom\out\Atom Dev x64\resources\app.asar.unpacked\node_modules\tree-sitter-html\build\Release\tree_sitter_html_binding.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
(node:31924) Electron: Loading non-context-aware native module in renderer: '\\?\C:\atom\out\Atom Dev x64\resources\app.asar.unpacked\node_modules\tree-sitter-java-dev\build\Release\tree_sitter_java_binding.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
(node:31924) Electron: Loading non-context-aware native module in renderer: '\\?\C:\atom\out\Atom Dev x64\resources\app.asar.unpacked\node_modules\tree-sitter-javascript\build\Release\tree_sitter_javascript_binding.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
(node:31924) Electron: Loading non-context-aware native module in renderer: '\\?\C:\atom\out\Atom Dev x64\resources\app.asar.unpacked\node_modules\tree-sitter-jsdoc\build\Release\tree_sitter_jsdoc_binding.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
(node:31924) Electron: Loading non-context-aware native module in renderer: '\\?\C:\atom\out\Atom Dev x64\resources\app.asar.unpacked\node_modules\tree-sitter-regex\build\Release\tree_sitter_regex_binding.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
(node:31924) Electron: Loading non-context-aware native module in renderer: '\\?\C:\atom\out\Atom Dev x64\resources\app.asar.unpacked\node_modules\tree-sitter-python\build\Release\tree_sitter_python_binding.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
(node:31924) Electron: Loading non-context-aware native module in renderer: '\\?\C:\atom\out\Atom Dev x64\resources\app.asar.unpacked\node_modules\tree-sitter-ruby\build\Release\tree_sitter_ruby_binding.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
(node:31924) Electron: Loading non-context-aware native module in renderer: '\\?\C:\atom\out\Atom Dev x64\resources\app.asar.unpacked\node_modules\tree-sitter-rust\build\Release\tree_sitter_rust_binding.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
(node:31924) Electron: Loading non-context-aware native module in renderer: '\\?\C:\atom\out\Atom Dev x64\resources\app.asar.unpacked\node_modules\tree-sitter-bash\build\Release\tree_sitter_bash_binding.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
(node:31924) Electron: Loading non-context-aware native module in renderer: '\\?\C:\atom\out\Atom Dev x64\resources\app.asar.unpacked\node_modules\tree-sitter-typescript\build\Release\tree_sitter_tsx_binding.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
(node:31924) Electron: Loading non-context-aware native module in renderer: '\\?\C:\atom\out\Atom Dev x64\resources\app.asar.unpacked\node_modules\tree-sitter-typescript\build\Release\tree_sitter_typescript_binding.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
(node:31924) Electron: Loading non-context-aware native module in renderer: '\\?\C:\atom\out\Atom Dev x64\resources\app.asar.unpacked\node_modules\@atom\nsfw\build\Release\nsfw.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.

DeeDeeG · 2021-02-24T02:53:51Z

With the latest commit 78c1bed, I can open Atom when there is a blank projectRoots in .atom/storage/application.json. 🎉

I do see a couple of errors in any window launched with blank projectRoots, though:

Failed to load a language-hyperlink package grammar

Cannot read property 'id' of undefined in /Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app.asar/node_modules/language-hyperlink/grammars/hyperlink.json

TypeError: Cannot read property 'id' of undefined
    at Function.startNextJob (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:14:915053)
    at SpellCheckTask.start (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:14:914555)
    at SpellCheckView.updateMisspellings (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:958275)
    at /Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:957703
    at Function.simpleDispatch (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:1182710)
    at Emitter.emit (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:1184151)
    at /Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:1:802120
    at Function.simpleDispatch (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:1182710)
    at Emitter.emit (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:1184151)
    at Text[user]LanguageMode.markTokenizationComplete (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:557198)
    at Text[user]LanguageMode.retokenizeLines (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:556151)
    at Text[user]LanguageMode.updateForInjection (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:555941)
    at /Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:360694
    at Map.forEach (<anonymous>)
    at GrammarRegistry.grammarAddedOrUpdated (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:360299)
    at Function.simpleDispatch (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:1182710)
    at Emitter.emit (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:1184151)
    at GrammarRegistry.addGrammar (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:14:120788)
    at Grammar.activate (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:14:127970)
    at /Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:3375172
    at /Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:362234
    at u (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:583651)
    at /Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:584904
    at electron/js2c/asar.js:533:9
    at FSReqCallback.wrapper [as oncomplete] (fs.js:470:5)
  at /Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app.asar/node_modules/language-hyperlink/grammars/hyperlink.json:1:1

Failed to load a language-todo package grammar

Cannot read property 'id' of undefined in /Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app.asar/node_modules/language-todo/grammars/todo.json

TypeError: Cannot read property 'id' of undefined
    at Function.startNextJob (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:14:915053)
    at SpellCheckTask.start (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:14:914555)
    at SpellCheckView.updateMisspellings (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:958275)
    at /Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:957703
    at Function.simpleDispatch (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:1182710)
    at Emitter.emit (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:1184151)
    at /Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:1:802120
    at Function.simpleDispatch (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:1182710)
    at Emitter.emit (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:1184151)
    at Text[user]LanguageMode.markTokenizationComplete (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:557198)
    at Text[user]LanguageMode.retokenizeLines (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:556151)
    at Text[user]LanguageMode.updateForInjection (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:555941)
    at /Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:360694
    at Map.forEach (<anonymous>)
    at GrammarRegistry.grammarAddedOrUpdated (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:360299)
    at Function.simpleDispatch (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:1182710)
    at Emitter.emit (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:1184151)
    at GrammarRegistry.addGrammar (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:14:120788)
    at Grammar.activate (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:14:127970)
    at /Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:3375172
    at /Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:362234
    at u (/Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:583651)
    at /Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app/static/<embedded>:11:584904
    at electron/js2c/asar.js:533:9
    at FSReqCallback.wrapper [as oncomplete] (fs.js:470:5)
  at /Users/[user]/Downloads/9-projectRoots-fix/Atom Dev.app/Contents/Resources/app.asar/node_modules/language-todo/grammars/todo.json:1:1

These are in the language-hyperlink and language-todo packages. Any window where there was a valid project path/folder in projectRoots does not show those errors.

It's on the PATH and is the version that will be used without needing to do update-alternatives.

mfonville · 2021-03-04T15:07:33Z

Electron went to 9.4.4:
#22003

aminya · 2021-03-05T17:28:24Z

Thanks for the work! 🎉

DeeDeeG · 2021-03-06T07:07:07Z

Wow! Electron 9 on master branch!! 🎉 🎉

the-j0k3r · 2021-03-06T08:04:54Z

@UziTech interesting to observe effect on terminus/x-terminal as well as all built in Atom addons though.

congrats @ all involved in these upgrades and finally merging in.

aminya · 2021-03-06T08:28:01Z

interesting to observe effect on terminus/x-terminal

If we integrate #21927, there will be no issues regarding the native addon.

the-j0k3r · 2021-03-06T08:41:15Z

If we integrate #21927, there will be no issues

indeed but only if that PR is merged into master before master code becomes a stable release. so we hope it is indeed merged asap.

- still depends on nodejs 10, which will be EOL starting May 2021 - template is very out of date (current version is 1.56.0), which shows lack of interest for the package - as seen in [1], depends on outdated electron9 (which void no longer provides) [1] atom/atom#21777

- still depends on nodejs 10, which will be EOL starting May 2021 - template is very out of date (current version is 1.56.0), which shows lack of interest for the package - as seen in [1], depends on outdated electron9 (which void no longer provides, if we wanted to use system electron), and that's a recent development [1] atom/atom#21777

sadick254 force-pushed the electron-upgrade-9.3.5 branch from a68719b to 1dd5f31 Compare December 1, 2020 18:45

UziTech mentioned this pull request Dec 1, 2020

electron v9.35 atom-community/zadeh#46

Closed

sadick254 force-pushed the electron-upgrade-9.3.5 branch 3 times, most recently from a7db5fa to 973178d Compare December 10, 2020 15:02

This was referenced Dec 10, 2020

fix: support dump_syms on macOS electron/node-minidump#40

Merged

Bump minidump @aminya/minidump@0.19.0-8 #21792

Merged

sadick254 force-pushed the electron-upgrade-9.3.5 branch from edb8122 to bac4998 Compare December 11, 2020 04:02

Daniel199604 approved these changes Dec 14, 2020

View reviewed changes

aminya mentioned this pull request Dec 16, 2020

Requiring debug breaks Atom's snapshot (blocking Electron upgrade) atom/spell-check#356

Closed

aminya mentioned this pull request Dec 16, 2020

Add enableDebug to config atom/spell-check#357

Merged

sadick254 force-pushed the electron-upgrade-9.3.5 branch from 7c35b18 to 21766a3 Compare December 16, 2020 16:45

aminya mentioned this pull request Dec 16, 2020

Bump winattr to @aminya/winattr@4.0.3 atom/text-buffer#336

Open

aminya mentioned this pull request Dec 16, 2020

fswin fails to build on Linux or MacOS xxoo/node-fswin#26

Closed

sadick254 force-pushed the electron-upgrade-9.3.5 branch from 298fce3 to 2f43d7c Compare February 22, 2021 18:55

Check before parsing

78c1bed

sadick254 force-pushed the electron-upgrade-9.3.5 branch from 2f43d7c to 78c1bed Compare February 22, 2021 19:22

sadick254 mentioned this pull request Feb 25, 2021

Fix github failing tests for Atom's electron 9.4.1 upgrade atom/github#2631

Merged

sadick254 added 2 commits March 1, 2021 19:44

⬆️ Bump spell-check@0.77.1

20f4e38

⬆️ Bump github@0.38.9

3a5617e

sadick254 force-pushed the electron-upgrade-9.3.5 branch from f1f0379 to 3a5617e Compare March 1, 2021 17:48

ThatXliner mentioned this pull request Mar 1, 2021

Apple M1 and Atom — will it work? #21688

Open

sadick254 added 2 commits March 2, 2021 21:02

Set --auto option

54ea7d6

Clang 9 is already in the image.

4af8166

It's on the PATH and is the version that will be used without needing to do update-alternatives.

sadick254 marked this pull request as ready for review March 3, 2021 15:36

Electron 9.4.4 (#22003)

00eca0b

sadick254 merged commit f4d832f into master Mar 5, 2021

sadick254 deleted the electron-upgrade-9.3.5 branch March 5, 2021 04:48

aminya mentioned this pull request Mar 11, 2021

Don't merge, just a test: Electron to 11.3.0 #22011

Closed

aminya mentioned this pull request Mar 24, 2021

Don't squash the commits into master #22081

Closed

1 task

DeeDeeG mentioned this pull request Mar 26, 2021

Release notes: Please mention Electron 9 upgrade for Atom 1.56.0-beta0 #22054

Closed

DeeDeeG mentioned this pull request Jun 2, 2021

Some tests are failing on Linux using (Atom built with) Electron 8 or newer atom/github#2688

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to electron 9.3.5 #21777

Upgrade to electron 9.3.5 #21777

sadick254 commented Dec 1, 2020 •

edited

mfonville commented Dec 2, 2020

aminya commented Dec 6, 2020

aminya commented Dec 10, 2020 •

edited

sadick254 commented Dec 10, 2020 •

edited

aminya commented Dec 10, 2020 •

edited

sadick254 commented Dec 10, 2020

mfonville commented Dec 10, 2020

aminya commented Dec 10, 2020 •

edited

aminya commented Dec 10, 2020

mfonville commented Dec 14, 2020

aminya commented Dec 16, 2020

aminya commented Dec 16, 2020

aminya commented Dec 16, 2020 •

edited

aminya commented Dec 16, 2020 •

edited

aminya commented Dec 16, 2020 •

edited

aminya commented Dec 16, 2020 •

edited

DeeDeeG commented Feb 24, 2021 •

edited

mfonville commented Mar 4, 2021

aminya commented Mar 5, 2021

DeeDeeG commented Mar 6, 2021

the-j0k3r commented Mar 6, 2021 •

edited

aminya commented Mar 6, 2021 •

edited

the-j0k3r commented Mar 6, 2021

Upgrade to electron 9.3.5 #21777

Upgrade to electron 9.3.5 #21777

Conversation

sadick254 commented Dec 1, 2020 • edited

TODO

Issues to resolve

Failing tests

Regressions to fix before merging

Known bugs resolved by this upgrade

Electron Upgrade Test Manifest

Check for regressions experienced in previous upgrades

Text Input/Keybindings

UI

Other

mfonville commented Dec 2, 2020

aminya commented Dec 6, 2020

aminya commented Dec 10, 2020 • edited

sadick254 commented Dec 10, 2020 • edited

aminya commented Dec 10, 2020 • edited

sadick254 commented Dec 10, 2020

mfonville commented Dec 10, 2020

aminya commented Dec 10, 2020 • edited

aminya commented Dec 10, 2020

mfonville commented Dec 14, 2020

aminya commented Dec 16, 2020

aminya commented Dec 16, 2020

aminya commented Dec 16, 2020 • edited

aminya commented Dec 16, 2020 • edited

aminya commented Dec 16, 2020 • edited

aminya commented Dec 16, 2020 • edited

DeeDeeG commented Feb 24, 2021 • edited

mfonville commented Mar 4, 2021

aminya commented Mar 5, 2021

DeeDeeG commented Mar 6, 2021

the-j0k3r commented Mar 6, 2021 • edited

aminya commented Mar 6, 2021 • edited

the-j0k3r commented Mar 6, 2021

sadick254 commented Dec 1, 2020 •

edited

aminya commented Dec 10, 2020 •

edited

sadick254 commented Dec 10, 2020 •

edited

aminya commented Dec 10, 2020 •

edited

aminya commented Dec 10, 2020 •

edited

aminya commented Dec 16, 2020 •

edited

aminya commented Dec 16, 2020 •

edited

aminya commented Dec 16, 2020 •

edited

aminya commented Dec 16, 2020 •

edited

DeeDeeG commented Feb 24, 2021 •

edited

the-j0k3r commented Mar 6, 2021 •

edited

aminya commented Mar 6, 2021 •

edited