Don't squash the commits into master

[aminya]

Prerequisites

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  • Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

Please don't squash the changes into the master branch. The Electron upgrade had 48 commits which could be used to track the issues of the change, but because it is squashed there is no way to see what issue comes from which change and you remove the logic behind the changes. Also, electron-upgrade-9.3.5 branch is removed which makes the situation worse. Many of the changes of this PR could be merged directly to master separately without the need for bumping Electron.

#21777

Also, people are used to assessing the life of a project based on the commits pushed to the master. When you squash 48 commits into 1, you simply make this huge change one commit.

Looking at this graph, no way you can guess that such a huge change has happened at this point!

In #22080, we were interested in testing the changes against a stable version of Atom, but this huge commit has changed many things in the tests making it unreliable to develop features/fixes against.

Expected behavior:

Merge commits normally:

Actual behavior:

Commits are squashed and the branch is deleted.

Reproduces how often:

100%

[sadick254]

It has been resolved internally that going forward we will continue merging commits normally. Without squashing. 👍

[aminya]

Thank you!