Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Add enableDebug to config #357

Merged
merged 7 commits into from Dec 16, 2020
Merged

Add enableDebug to config #357

merged 7 commits into from Dec 16, 2020

Conversation

aminya
Copy link
Contributor

@aminya aminya commented Dec 16, 2020 •
edited

Description of the Change

  • Makes debug loading lazy and hides it behind a setting. This is inline with Atom's snapshot system
  • This adds a config which allows to enable or disable debug

Alternate Designs

Benefits

  • Allows spell-check to be included in the snapshot -> Unblocks Upgrade to electron 9.3.5 atom#21777
  • Adding UI for debugging makes it easier for normal users to enable/disable debugging.
  • No extra overhead because of debug package.
  • Loading time is decreased from 29ms to 15ms

Possible Drawbacks

N/A

Applicable Issues

Fixes #356

@aminya aminya marked this pull request as ready for review December 16, 2020 04:24
@aminya
Copy link
Contributor Author

aminya commented Dec 16, 2020 •
edited

@sadick254 This probably unblocks Electron upgrade

sadick254
sadick254 approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@sadick254 sadick254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@sadick254 sadick254 merged commit 071a3c0 into atom:master Dec 16, 2020
@dmoonfire dmoonfire mentioned this pull request Apr 4, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sadick254 sadick254 sadick254 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Requiring debug breaks Atom's snapshot (blocking Electron upgrade)
2 participants
@aminya @sadick254