Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Bump winattr to @aminya/winattr@4.0.3 #336

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aminya
Copy link
Contributor

@aminya aminya commented Dec 16, 2020

Description of the change

This replaces winattr with the promisified version which is registered under my name.
https://github.com/aminya/winattr

This also bumps fswin (a dependency of winattr), which may solve the issue of fswin.node in Linux/MacOS for Electron upgrade. atom/atom#21777

Benefits

  • Promisifed
  • fswin bumped

Verification

Tests pass

Release Notes

  • Bump winattr

@sadick254
Copy link
Contributor

sadick254 commented Dec 17, 2020

This doesn't resolve the issue on linux and macOS I still experience the same error while trying to build atom.

Screenshot 2020-12-17 at 08 52 18

@aminya
Copy link
Contributor Author

aminya commented Dec 17, 2020

@sadick254 Should we just add copy-paste the error message and ignore it when we hit it as an exception? fswin binary is not used on Mac or Linux.

https://github.com/atom/atom/blob/f1b0e3b47b30ed9379821b341b3337696b8a2a12/script/lib/dump-symbols.js#L31

if (process.platform !== 'win32' && error.match(/fswin.node/)) return resolve();

@sadick254
Copy link
Contributor

@aminya We can do that and add a comment. That would work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants