New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): remove static dependency from @angular/core to @angular/compiler #26734
Conversation
You can preview 8f6091c at https://pr26734-8f6091c.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the peerDependency for compiler be dropped?
angular/packages/core/package.json
Line 19 in 9dc52d9
"@angular/compiler": "0.0.0-PLACEHOLDER", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some changes requested but the rest looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool! A few minor comments.
Can this PR be merged to patch and go out in the next 7.0.x release? Otherwise CLI needs to do more work to compensate. |
d90aefc
to
9ad8478
Compare
You can preview 9ad8478 at https://pr26734-9ad8478.ngbuilds.io/. |
dbc2960
to
c0b56ff
Compare
You can preview c0b56ff at https://pr26734-c0b56ff.ngbuilds.io/. |
You can preview 57f3dec at https://pr26734-57f3dec.ngbuilds.io/. |
57f3dec
to
029d8fb
Compare
You can preview 63b9af5 at https://pr26734-63b9af5.ngbuilds.io/. |
63b9af5
to
0fe5d1a
Compare
0fe5d1a
to
db531c9
Compare
You can preview 98f38b6 at https://pr26734-98f38b6.ngbuilds.io/. |
98f38b6
to
66ecc41
Compare
66ecc41
to
8cf90f4
Compare
You can preview 8cf90f4 at https://pr26734-8cf90f4.ngbuilds.io/. |
You can preview 5d257f6 at https://pr26734-5d257f6.ngbuilds.io/. |
4172b5f
to
bb6a3ed
Compare
bb6a3ed
to
c4f71ff
Compare
…ular/compiler (angular#26734) PR Close angular#26734
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
With Ivy we need
@Component
decorator to compile the component. For this reason@Component
depends on@angular/compiler
. We expect that the the compiler will than be tree-shaken away as part of the production build.Unfortunately the
@angular/compiler
is large enough that the mare act of parsing and loading (even if not executing) is causing negative build time regression. This change fixes this by making the dependency between@Component
decorator and@angular/compiler
to be late bound (runtime) rather than statically bound (compile time).This means that for JIT mode it is not sufficient to just load
@angular/core
to have@angular/compiler
loaded. Instead it is necessary to load@angular/compiler
either explicitly or implicitly thought@angular/platform-browser-dynamic
.