Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): upgrade to 7.0 #481

Merged
merged 1 commit into from
Nov 10, 2018
Merged

Conversation

trotyl
Copy link
Contributor

@trotyl trotyl commented Oct 30, 2018

Summary

Notes for Ivy implementation

  • Failed with closure compiler, switched to rollup for now, should have little difference in speed (but size would grow);
  • Now using real @angular/common library rather than custom picked NgForOf codes with ngcc tooling support;
  • Add a patch script in postinstall due to ngcc issues;

@trotyl trotyl changed the title feat(angular): upgrade to 7.0 [WIP] feat(angular): upgrade to 7.0 Oct 30, 2018
@trotyl trotyl changed the title [WIP] feat(angular): upgrade to 7.0 feat(angular): upgrade to 7.0 Oct 30, 2018
@trotyl
Copy link
Contributor Author

trotyl commented Oct 30, 2018

CI failure unrelated.

@krausest krausest merged commit ee9e19f into krausest:master Nov 10, 2018
@krausest
Copy link
Owner

Thanks! BTW I (hope I) disabled CI for pull request - too many false positives.
Here are the results:
bildschirmfoto 2018-11-10 um 22 19 29

@trotyl trotyl deleted the angular-v7.0 branch November 12, 2018 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants