fix(core): Remove static dependency from @angular/core to @angular/co…

…mpiler (angular#26734)

PR Close angular#26734

packages/compiler-cli/src/ngtsc/annotations/src/directive.ts

@@ -332,8 +332,9 @@ function parseFieldToPropertyMapping(
  */
 function parseDecoratedFields(
     fields: {member: ClassMember, decorators: Decorator[]}[], reflector: ReflectionHost,
-    checker: ts.TypeChecker, mapValueResolver: (publicName: string, internalName: string) =>
-                                 string | string[]): {[field: string]: string | string[]} {
+    checker: ts.TypeChecker,
+    mapValueResolver: (publicName: string, internalName: string) =>
+        string | [string, string]): {[field: string]: string | [string, string]} {
   return fields.reduce(
       (results, field) => {
         const fieldName = field.member.name;
@@ -356,10 +357,10 @@ function parseDecoratedFields(
         });
         return results;
       },
-      {} as{[field: string]: string | string[]});
+      {} as{[field: string]: string | [string, string]});
 }
 
-function resolveInput(publicName: string, internalName: string) {
+function resolveInput(publicName: string, internalName: string): [string, string] {
   return [publicName, internalName];
 }
 

packages/compiler/package.json

@@ -22,5 +22,5 @@
   "ng-update": {
     "packageGroup": "NG_UPDATE_PACKAGE_GROUP"
   },
-  "sideEffects": false
-}
+  "sideEffects": true
+}

packages/compiler/src/compiler.ts

@@ -6,6 +6,11 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
+//////////////////////////////////////
+// THIS FILE HAS GLOBAL SIDE EFFECT //
+//       (see bottom of file)       //
+//////////////////////////////////////
+
 /**
  * @module
  * @description
@@ -23,6 +28,8 @@
  */
 
 import * as core from './core';
+import {publishFacade} from './jit_compiler_facade';
+import {global} from './util';
 
 export {core};
 
@@ -91,4 +98,9 @@ export {compilePipeFromMetadata, R3PipeMetadata} from './render3/r3_pipe_compile
 export {makeBindingParser, parseTemplate} from './render3/view/template';
 export {R3Reference} from './render3/util';
 export {compileBaseDefFromMetadata, R3BaseRefMetaData, compileComponentFromMetadata, compileDirectiveFromMetadata, parseHostBindings} from './render3/view/compiler';
+export {publishFacade} from './jit_compiler_facade';
 // This file only reexports content of the `src` folder. Keep it that way.
+
+// This function call has a global side effects and publishes the compiler into global namespace for
+// the late binding of the Compiler to the @angular/core for jit compilation.
+publishFacade(global);

packages/compiler/src/compiler_facade_interface.ts

@@ -0,0 +1,145 @@
+/**
+ * @license
+ * Copyright Google Inc. All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.io/license
+ */
+
+
+/**
+ * A set of interfaces which are shared between `@angular/core` and `@angular/compiler` to allow
+ * for late binding of `@angular/compiler` for JIT purposes.
+ *
+ * This file has two copies. Please ensure that they are in sync:
+ *  - packages/compiler/src/compiler_facade_interface.ts             (master)
+ *  - packages/core/src/render3/jit/compiler_facade_interface.ts     (copy)
+ *
+ * Please ensure that the two files are in sync using this command:
+ * ```
+ * cp packages/compiler/src/compiler_facade_interface.ts \
+ *    packages/core/src/render3/jit/compiler_facade_interface.ts
+ * ```
+ */
+
+export interface ExportedCompilerFacade { ɵcompilerFacade: CompilerFacade; }
+
+export interface CompilerFacade {
+  compilePipe(angularCoreEnv: CoreEnvironment, sourceMapUrl: string, meta: R3PipeMetadataFacade):
+      any;
+  compileInjectable(
+      angularCoreEnv: CoreEnvironment, sourceMapUrl: string, meta: R3InjectableMetadataFacade): any;
+  compileInjector(
+      angularCoreEnv: CoreEnvironment, sourceMapUrl: string, meta: R3InjectorMetadataFacade): any;
+  compileNgModule(
+      angularCoreEnv: CoreEnvironment, sourceMapUrl: string, meta: R3NgModuleMetadataFacade): any;
+  compileDirective(
+      angularCoreEnv: CoreEnvironment, sourceMapUrl: string, meta: R3DirectiveMetadataFacade): any;
+  compileComponent(
+      angularCoreEnv: CoreEnvironment, sourceMapUrl: string, meta: R3ComponentMetadataFacade): any;
+
+  R3ResolvedDependencyType: typeof R3ResolvedDependencyType;
+}
+
+export interface CoreEnvironment { [name: string]: Function; }
+
+export type StringMap = {
+  [key: string]: string;
+};
+
+export type StringMapWithRename = {
+  [key: string]: string | [string, string];
+};
+
+export type Provider = any;
+
+export enum R3ResolvedDependencyType {
+  Token = 0,
+  Attribute = 1,
+}
+
+export interface R3DependencyMetadataFacade {
+  token: any;
+  resolved: R3ResolvedDependencyType;
+  host: boolean;
+  optional: boolean;
+  self: boolean;
+  skipSelf: boolean;
+}
+
+export interface R3PipeMetadataFacade {
+  name: string;
+  type: any;
+  pipeName: string;
+  deps: R3DependencyMetadataFacade[]|null;
+  pure: boolean;
+}
+
+export interface R3InjectableMetadataFacade {
+  name: string;
+  type: any;
+  ctorDeps: R3DependencyMetadataFacade[]|null;
+  providedIn: any;
+  useClass?: any;
+  useFactory?: any;
+  useExisting?: any;
+  useValue?: any;
+  userDeps?: R3DependencyMetadataFacade[];
+}
+
+export interface R3NgModuleMetadataFacade {
+  type: any;
+  bootstrap: Function[];
+  declarations: Function[];
+  imports: Function[];
+  exports: Function[];
+  emitInline: boolean;
+}
+
+export interface R3InjectorMetadataFacade {
+  name: string;
+  type: any;
+  deps: R3DependencyMetadataFacade[]|null;
+  providers: any;
+  imports: any;
+}
+
+export interface R3DirectiveMetadataFacade {
+  name: string;
+  type: any;
+  typeArgumentCount: number;
+  typeSourceSpan: null;
+  deps: R3DependencyMetadataFacade[]|null;
+  selector: string|null;
+  queries: R3QueryMetadataFacade[];
+  host: {[key: string]: string};
+  propMetadata: {[key: string]: any[]};
+  lifecycle: {usesOnChanges: boolean;};
+  inputs: string[];
+  outputs: string[];
+  usesInheritance: boolean;
+  exportAs: string|null;
+  providers: Provider[]|null;
+}
+
+export interface R3ComponentMetadataFacade extends R3DirectiveMetadataFacade {
+  template: string;
+  preserveWhitespaces: boolean;
+  animations: any[]|undefined;
+  viewQueries: R3QueryMetadataFacade[];
+  pipes: Map<string, any>;
+  directives: Map<string, any>;
+  styles: string[];
+  encapsulation: ViewEncapsulation;
+  viewProviders: Provider[]|null;
+}
+
+export type ViewEncapsulation = number;
+
+export interface R3QueryMetadataFacade {
+  propertyName: string;
+  first: boolean;
+  predicate: any|string[];
+  descendants: boolean;
+  read: any|null;
+}