Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): taking "interpolation" config option into account (FW-723) #27363

Closed

Conversation

AndrewKushnir
Copy link
Contributor

This PR introduces support for interpolation config option that you can define at @Component level. Corresponding tests were added and the TestBed one was unblocked.

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature

Does this PR introduce a breaking change?

  • Yes
  • No

@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release comp: ivy labels Nov 30, 2018
@ngbot ngbot bot added this to the needsTriage milestone Nov 30, 2018
@angular angular deleted a comment from mary-poppins Nov 30, 2018
@angular angular deleted a comment from mary-poppins Nov 30, 2018
@AndrewKushnir AndrewKushnir force-pushed the FW-723_interpolation_config_2 branch 2 times, most recently from 00d38d8 to 2c1fd39 Compare November 30, 2018 18:55
@angular angular deleted a comment from mary-poppins Dec 1, 2018
@angular angular deleted a comment from mary-poppins Dec 1, 2018
@angular angular deleted a comment from mary-poppins Dec 1, 2018
@angular angular deleted a comment from mary-poppins Dec 1, 2018
@mary-poppins
Copy link

You can preview 6236107 at https://pr27363-6236107.ngbuilds.io/.

Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AndrewKushnir
Copy link
Contributor Author

Thanks for the review @alxhub!

@AndrewKushnir
Copy link
Contributor Author

Presubmit

@angular angular deleted a comment from mary-poppins Dec 4, 2018
@angular angular deleted a comment from mary-poppins Dec 4, 2018
@mary-poppins
Copy link

You can preview 0c074f2 at https://pr27363-0c074f2.ngbuilds.io/.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: merge The PR is ready for merge by the caretaker labels Dec 4, 2018
@mhevery mhevery added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 4, 2018
@IgorMinar IgorMinar closed this in 8e644d9 Dec 4, 2018
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants