Skip to content

Commit

Permalink
fixup! fix(core): remove static dependency from @angular/core to @ang…
Browse files Browse the repository at this point in the history
…ular/compiler
  • Loading branch information
mhevery committed Oct 25, 2018
1 parent 63a557e commit 9ad8478
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 3 deletions.
4 changes: 2 additions & 2 deletions packages/compiler/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@
"ng-update": {
"packageGroup": "NG_UPDATE_PACKAGE_GROUP"
},
"sideEffects": false
}
"sideEffects": true
}
11 changes: 11 additions & 0 deletions packages/compiler/src/compiler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@
* found in the LICENSE file at https://angular.io/license
*/

//////////////////////////////////////
// THIS FILE HAS GLOBAL SIDE EFFECT //
// (see bottom of file) //
//////////////////////////////////////

/**
* @module
* @description
Expand All @@ -23,6 +28,8 @@
*/

import * as core from './core';
import {publishFacade} from './jit_compiler_facade';
import {global} from './util';

export {core};

Expand Down Expand Up @@ -93,3 +100,7 @@ export {R3Reference} from './render3/util';
export {compileBaseDefFromMetadata, R3BaseRefMetaData, compileComponentFromMetadata, compileDirectiveFromMetadata, parseHostBindings} from './render3/view/compiler';
export {publishFacade} from './jit_compiler_facade';
// This file only reexports content of the `src` folder. Keep it that way.

// This function call has a global side effects and publishes the compiler into global namespace for
// the late binding of the Compiler to the @angular/core for jit compilation.
publishFacade(global);
1 change: 0 additions & 1 deletion packages/compiler/src/util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,6 @@ export interface Console {
}


// TODO(jteplitz602): Load WorkerGlobalScope from lib.webworker.d.ts file #3492
declare var WorkerGlobalScope: any;
// CommonJS / Node have global context exposed as "global" variable.
// We don't want to include the whole node.d.ts this this compilation unit so we'll just fake
Expand Down

0 comments on commit 9ad8478

Please sign in to comment.