New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Review app Sass compile after error #4239
Conversation
This ensures Gulp can still catch errors without “Did you forget to signal async completion?”
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for 089b280 |
Unlike Sass and npm scripts, Rollup includes error properties from Babel such as: Details: code: PLUGIN_ERROR reasonCode: UnexpectedToken loc: [object Object] pos: 13330 pluginCode: BABEL_PARSE_ERROR hook: transform
41fd5b7
to
e8a9a2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops! So easy to miss these await
. Thanks for the little tidy-ups around as well :D
Thanks @romaricpascal Just need to confirm those error codes etc in Windows before merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌🏻
The previous commit lets Gulp hande `new PluginError()` versus logging to console, so we now need to skip typical “watch + restart” errors seen during development
e8a9a2e
to
089b280
Compare
To avoid unnecessary error logging on Windows I've silenced
Don't want to make Ctrl + C too noisy on Windows if we can avoid it there too |
This PR fixes Gulp "Did you forget to signal async completion?" when Sass compilation errors occur in:
The issue
Spot my missing
await
in 8f74d02 🤦♂️Error logging
I've made sure all "watch + reload" tasks use Gulp's
new PluginError()
for consistent output, as currently:scripts.compile()
thrownew PluginError()
styles.compile()
thrownew PluginError()
npm.script()
logconsole.error(error.message)
without errorBut Gulp is now aware of npm task errors too, without interrupting watch tasks: