Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The review app stops compiling Sass after encountering an error #4237

Closed
36degrees opened this issue Sep 20, 2023 · 1 comment · Fixed by #4239
Closed

The review app stops compiling Sass after encountering an error #4237

36degrees opened this issue Sep 20, 2023 · 1 comment · Fixed by #4239
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) tooling

Comments

@36degrees
Copy link
Member

36degrees commented Sep 20, 2023

Description of the issue

If you make a change that causes an error in Sass compliation whilst using the review app, the build process for the review app crashes and is not restarted.

This means that even if you fix the change, you need to stop the process and restart it (Ctrl + C then re-run npm start).

Steps to reproduce the issue

  1. Run npm start
  2. Edit *.scss file to cause a Sass or PostCSS error

Actual vs expected behaviour

Expected behaviour:

The error is outputted on the console and the watch task for the review app build continues to retry compilation when further changes are made

Actual behaviour:

The error is outputted on the console but the watch task for the review app build crashes.

Environment (where applicable)

  • Operating system: macOS 13.5.1
  • Browser: N/A
  • Browser version: N/A
  • GOV.UK Frontend Version: N/A (happening on main branch)
@36degrees 36degrees added 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) tooling labels Sep 20, 2023
@colinrotherham colinrotherham self-assigned this Sep 20, 2023
@colinrotherham
Copy link
Contributor

Will be fixed by #4239 and tested in #4240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) tooling
Projects
Development

Successfully merging a pull request may close this issue.

2 participants