Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Review app Sass compile after error #4239

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Commits on Sep 20, 2023

  1. Fix missing await before Sass compile

    This ensures Gulp can still catch errors without “Did you forget to signal async completion?”
    colinrotherham committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    c4bf278 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    784302f View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Always pass friendly formatted errors into Gulp

    Unlike Sass and npm scripts, Rollup includes error properties from Babel such as:
    
    Details:
        code: PLUGIN_ERROR
        reasonCode: UnexpectedToken
        loc: [object Object]
        pos: 13330
        pluginCode: BABEL_PARSE_ERROR
        hook: transform
    colinrotherham committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    0032c33 View commit details
    Browse the repository at this point in the history
  2. Skip Nodemon (SIGINT) exit or aborted task errors

    The previous commit lets Gulp hande `new PluginError()` versus logging to console, so we now need to skip typical “watch + restart” errors seen during development
    colinrotherham committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    089b280 View commit details
    Browse the repository at this point in the history