Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new govuk-frontend.min.css package bundle #4240

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Conversation

colinrotherham
Copy link
Contributor

To make sure we catch Sass compilation problems early, our npm package has a new minified bundle

Previously we ran PostCSS-only tasks during npm run build:package and missed #4239

Package minified bundles

Output using npm run build:package

  • govuk-frontend.min.js
  • govuk-frontend.min.css ✅ Added

GitHub Release minified bundles

Using npm run build:release

  • govuk-frontend-X.Y.Z.min.js
  • govuk-frontend-X-Y-Z.min.css

@colinrotherham colinrotherham linked an issue Sep 21, 2023 that may be closed by this pull request
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4240 September 21, 2023 08:06 Inactive
@github-actions
Copy link

github-actions bot commented Sep 21, 2023

📋 Stats

File sizes

File Size
dist/govuk-frontend-4.6.0.min.css 118.07 KiB
dist/govuk-frontend-4.6.0.min.js 47.1 KiB
dist/govuk-frontend-ie8-4.6.0.min.css 79.27 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 76.96 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 72.29 KiB
packages/govuk-frontend/dist/govuk/all.mjs 3.84 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 120.45 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 37.41 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.83 KiB

Modules

File Size
all.mjs 68.39 KiB
components/accordion/accordion.mjs 21.9 KiB
components/button/button.mjs 4.71 KiB
components/character-count/character-count.mjs 21.64 KiB
components/checkboxes/checkboxes.mjs 5.69 KiB
components/error-summary/error-summary.mjs 6.01 KiB
components/exit-this-page/exit-this-page.mjs 16.6 KiB
components/header/header.mjs 3.83 KiB
components/notification-banner/notification-banner.mjs 4.54 KiB
components/radios/radios.mjs 4.68 KiB
components/skip-link/skip-link.mjs 3.73 KiB
components/tabs/tabs.mjs 9.07 KiB

View stats and visualisations on the review app


Action run for 04e64dd

@36degrees
Copy link
Member

I've split this from #4237 as it's related but I think we can call it done – will add this to the board separately.

It’s a bit misleading calling them `compile:scss` since we skip the Sass compiler when outputing from Sass to Sass
We can simplify our build and watch globs now the IE8 stylesheet has been removed
Copy link
Member

@romaricpascal romaricpascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Checked the output and it's the same as the one in dist (except the source map URL, obviously) 🙌🏻

Could you add a little entry to the CHANGELOG, please? then all good to go 🥳

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4240 September 26, 2023 15:37 Inactive
@colinrotherham
Copy link
Contributor Author

Thanks @romaricpascal

Could you add a little entry to the CHANGELOG, please? then all good to go 🥳

✅ Done

Copy link
Member

@romaricpascal romaricpascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers for adding the changelog entry! 😊 Looks good to merge on the tech side. @claireashworth let us know if the CHANGELOG entry looks fine.

Copy link
Contributor

@claireashworth claireashworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've made a note of this to add to my doc. This looks good, but there's a chance it'll get slightly amended when I edit this change into the release notes draft.

@colinrotherham colinrotherham merged commit e2cc3af into main Sep 26, 2023
44 checks passed
@colinrotherham colinrotherham deleted the styles-in-package branch September 26, 2023 16:10
colinrotherham added a commit that referenced this pull request Sep 27, 2023
Add new `govuk-frontend.min.css` package bundle
@colinrotherham colinrotherham removed their assignment Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants