-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new govuk-frontend.min.css
package bundle
#4240
Conversation
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for 04e64dd |
d359da9
to
9d73f64
Compare
9d73f64
to
1e93a54
Compare
e8a9a2e
to
089b280
Compare
1e93a54
to
f81672b
Compare
I've split this from #4237 as it's related but I think we can call it done – will add this to the board separately. |
It’s a bit misleading calling them `compile:scss` since we skip the Sass compiler when outputing from Sass to Sass
We can simplify our build and watch globs now the IE8 stylesheet has been removed
f81672b
to
b83a894
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat! Checked the output and it's the same as the one in dist
(except the source map URL, obviously) 🙌🏻
Could you add a little entry to the CHANGELOG, please? then all good to go 🥳
Thanks @romaricpascal
✅ Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers for adding the changelog entry! 😊 Looks good to merge on the tech side. @claireashworth let us know if the CHANGELOG entry looks fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I've made a note of this to add to my doc. This looks good, but there's a chance it'll get slightly amended when I edit this change into the release notes draft.
Add new `govuk-frontend.min.css` package bundle
To make sure we catch Sass compilation problems early, our npm package has a new minified bundle
Previously we ran PostCSS-only tasks during
npm run build:package
and missed #4239Package minified bundles
Output using
npm run build:package
govuk-frontend.min.js
govuk-frontend.min.css
✅ AddedGitHub Release minified bundles
Using
npm run build:release
govuk-frontend-X.Y.Z.min.js
govuk-frontend-X-Y-Z.min.css