Support .nvmrc #338

hkaur008 · 2021-09-30T19:38:01Z

Description

In scope of this pull request we add Node.js version file support. This pull request introduces new optional input: node-version-file, that accepts path (relative to repository root) to file containing Node.js version (for example .nvmrc).

The action will search for the Node.js version file and read the Node.js version if the file exists. If both inputs node-version and node-version-file are specified, the action will throw a warning and the node-version input will be used.

Example of yml

steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
  with:
    node-version-file: '.nvmrc'
- run: npm install
- run: npm test

Related issue: #32

What's done:

- Adding Node.js version file support
- Adding tests
- Updating documentation

… '.nvmrc'

This reverts commit 820128a.

… pull209

hkaur008 · 2021-10-04T23:20:35Z

Is this reviewable now @Xlient I think we did all the tasks !

src/installer.ts

__tests__/installer.test.ts

added link to README * migrated contents of version-file-workflow.yml to versions.yml * further refactored parseNodeVersionFile() & tests * removed type annotations in catch ()

* added fail-fast to strategy in versions.yml * refactored logic in main that was causing test to fail

docs/advanced-usage.md

README.md

src/main.ts

action.yml

* fix grammar in README & Advance usage docs * update example in action.yml

src/main.ts

Since actions/setup-node#338, GH's setup-node Action understands `.nvmrc` files. This makes our `guardian/actions-setup-node` fork somewhat redundant now. Move to GH's Action so we can deprecate our fork.

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.5.2 to 4.5.3. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v4.5.2...v4.5.3) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

TJMcCarthy95 and others added 3 commits November 1, 2020 17:30

Implemented support for repository defined node version files such as…

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

c3812bd

… '.nvmrc'

Expand node version file support to include lts based codenames

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

a0d376d

fixed missing brackets and merged main

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

75c8584

hkaur008 marked this pull request as draft September 30, 2021 19:41

hkaur008 changed the title ~~Pull 209~~ Support .nvmrc Sep 30, 2021

Xlient and others added 13 commits September 30, 2021 20:22

test commit ignore

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

820128a

Revert "test commit ignore"

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

ac10981

This reverts commit 820128a.

fixed merge conflicts

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

bca2818

Refactored code and removed redundant logic

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

82441b3

created test workflow & nvmrc file

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

052bc8b

fixed error in workflow file

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

1f26500

Update version-file-workflow.yml

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

510ffc9

fixed merge conflicts

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

2579409

Merge branch 'pull209' of https://github.com/hkaur008/setup-node into…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

1650600

… pull209

refactored installer.test.ts

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

2fb803b

deleted node-version-file

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

42c8cd4

code syntax matched

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

e471f47

Xlient suggested changes Oct 5, 2021

View reviewed changes

src/installer.ts Outdated Show resolved Hide resolved

__tests__/installer.test.ts Outdated Show resolved Hide resolved

Xlient added 2 commits October 5, 2021 15:01

removed test logic in ParseNodeVersionFile for lts and partial matching

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

c178bbb

Xlient force-pushed the pull209 branch from 7988930 to c178bbb Compare October 5, 2021 16:58

hkaur008 and others added 7 commits October 5, 2021 23:00

removed extra tabs (versions.yml)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

eb7c472

removed extra tabs (versions.yml)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

7fb46ef

removed unnessary test

ec979d0

* added fail-fast to strategy in versions.yml * refactored logic in main that was causing test to fail

Delete index.js

fe30936

added correct path to version file

7d40f6c

build successful

6e5214f

build successful

5b7f417

konradpabjan approved these changes Nov 16, 2021

View reviewed changes

docs/advanced-usage.md Outdated Show resolved Hide resolved

docs/advanced-usage.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

src/main.ts Outdated Show resolved Hide resolved

action.yml Outdated Show resolved Hide resolved

adds path to error output

4e4d327

* fix grammar in README & Advance usage docs * update example in action.yml

bryanmacfarlane reviewed Nov 17, 2021

View reviewed changes

src/main.ts Outdated Show resolved Hide resolved

bryanmacfarlane reviewed Nov 17, 2021

View reviewed changes

src/main.ts Show resolved Hide resolved

hkaur008 added 4 commits November 22, 2021 18:27

import os = require('os'); moved back

a2b4d83

Merge remote-tracking branch 'refs/remotes/origin/pull209' into pull209

e75d7c1

build

0f9cdab

removed n-node-version file

a7ed1ce

MaksimZhukov approved these changes Nov 28, 2021

View reviewed changes

MaksimZhukov merged commit d08cf22 into actions:main Nov 29, 2021

jameswald mentioned this pull request Nov 30, 2021

Support .nvmrc #32

Closed

travi mentioned this pull request Nov 30, 2021

simplify use of the nvmrc file form8ion/github-actions-node-ci#479

Closed

ganta mentioned this pull request Dec 2, 2021

Add support for asdf format as Node.js version file #373

Merged

2 tasks

y-nk mentioned this pull request Dec 10, 2021

Implicit set of node-version based on .nvmrc #377

Closed

akash1810 mentioned this pull request Jan 5, 2022

Use GitHub Actions for CI guardian/gateway#1349

Merged

This was referenced Jan 10, 2022

Update actions/setup-node to v2 hashicorp/vscode-terraform#897

Merged

use node-version-file with actions/setup-node@v2 hashicorp/js-releases#14

Merged

akash1810 mentioned this pull request Jan 20, 2022

Adds generic sbt node snyk workflow guardian/.github#11

Merged

akash1810 mentioned this pull request Jan 27, 2022

chore(ci): Use GH's setup-node Action guardian/cdk#1062

Merged

revolunet mentioned this pull request Mar 7, 2022

ci: switch from gitlab to github SocialGouv/cdtn-admin#723

Merged

jablko mentioned this pull request May 2, 2022

Support lts/-n aliases #481

Merged

2 tasks

pepopowitz mentioned this pull request Jun 17, 2022

fix: resolve broken builds by updating package-lock and specify node version via .nvmrc camunda/camunda-docs#976

Merged

pepopowitz mentioned this pull request Jun 28, 2022

Synchronize node version between CI & local camunda/camunda-docs#997

Closed

2 tasks

sndrs mentioned this pull request Oct 10, 2022

retire guardian/actions-setup-node guardian/actions-setup-node#9

Closed

stefafafan mentioned this pull request Dec 6, 2022

Suggestion: perl-version-file input support? shogo82148/actions-setup-perl#1359

Closed

stephenkao mentioned this pull request Mar 7, 2023

Update to Node 18.15 CDCgov/prime-reportstream#8631

Merged

ahukkanen mentioned this pull request Mar 21, 2023

Use node-version-file configuration for the CI decidim/documentation#119

Merged

chenrui333 mentioned this pull request Dec 21, 2023

feat: bump to use node20 runtime peaceiris/actions-hugo#641

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support .nvmrc #338

Support .nvmrc #338

hkaur008 commented Sep 30, 2021 •

edited by MaksimZhukov

Loading

hkaur008 commented Oct 4, 2021

Support .nvmrc #338

Support .nvmrc #338

Conversation

hkaur008 commented Sep 30, 2021 • edited by MaksimZhukov Loading

Description

Example of yml

Related issue: #32

What's done:

hkaur008 commented Oct 4, 2021

hkaur008 commented Sep 30, 2021 •

edited by MaksimZhukov

Loading