Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implicit set of node-version based on .nvmrc #377

Closed
y-nk opened this issue Dec 10, 2021 · 1 comment
Closed

Implicit set of node-version based on .nvmrc #377

y-nk opened this issue Dec 10, 2021 · 1 comment
Labels
feature request New feature or request to improve the current logic

Comments

@y-nk
Copy link

y-nk commented Dec 10, 2021

Description:
the default value of the node-version should be extracted from a .nvmrc file if this file has been found

Justification:
Avoid duplicated source of truth and possible build mismatch

Are you willing to submit a PR?
yes
@y-nk y-nk added feature request New feature or request to improve the current logic needs triage labels Dec 10, 2021
@y-nk
Copy link
Author

y-nk commented Dec 10, 2021

Just saw this #338

@y-nk y-nk closed this as completed Dec 10, 2021
deining pushed a commit to deining/setup-node that referenced this issue Nov 9, 2023
@allcontributors
docs: add Josh-Cena as a contributor for bug (actions#377)
7fbfbfa 
* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@y-nk @MaksimZhukov