Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize node version between CI & local #997

Open
2 tasks
pepopowitz opened this issue Jun 28, 2022 · 0 comments
Open
2 tasks

Synchronize node version between CI & local #997

pepopowitz opened this issue Jun 28, 2022 · 0 comments
Labels
component:docs Documentation improvements, including new or updated content dx Documentation infrastructure typically handled by the Camunda DX team

Comments

@pepopowitz
Copy link
Collaborator

This is followup work to #976.

In that PR we introduced a .nvmrc file to specify node versions for local environments. It does not currently match the exact specified version for CI, though (16.15.1 vs 16). We should synchronize these versions.

Included in this work

  • Configure any actions that are hardcoding the node version number to get the node version from the .nvmrc file. This change is described and demonstrated in actions/setup-node#338.
  • Decide whether we want to specify only the major version (16), or the fully qualified version (16.15.1). The tradeoffs:
    • Specifying the major version gives us free node patch/minor version updates on CI, but it doesn't guarantee that local and CI would use the same fully qualified version.
    • Specifying the fully qualified version guarantees that local and CI are using the same version, but to get node version updates we have to manually update the nvmrc.
@pepopowitz pepopowitz added component:docs Documentation improvements, including new or updated content dx Documentation infrastructure typically handled by the Camunda DX team labels Jun 28, 2022
@pepopowitz pepopowitz self-assigned this Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content dx Documentation infrastructure typically handled by the Camunda DX team
Projects
Status: 🆕 Inbox
Development

No branches or pull requests

1 participant