Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support lts/-n aliases #481

Merged
merged 5 commits into from Jun 2, 2022
Merged

Support lts/-n aliases #481

merged 5 commits into from Jun 2, 2022

Conversation

jablko
Copy link
Contributor

@jablko jablko commented May 2, 2022

Description:
#270 added support for lts/<alias> and lts/* nvm aliases. This adds support for nvm's (and hence .nvmrc/node-version-file's) lts/-n: nvm-sh/nvm#1998 (comment)

Related issue:
#481

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@jablko jablko requested a review from a team May 2, 2022 20:01
@e-korolevskii
Copy link
Contributor

Hi, @jablko,

You need to manually run build and add the results to the PR.

Cheers.

@jablko
Copy link
Contributor Author

jablko commented May 6, 2022

  • Thank you @e-korolevskii! I've added the build products to the commit.

@dmitry-shibanov
Copy link
Contributor

Hello @jablko. Could you please add e2e tests for new syntax ?

@jablko
Copy link
Contributor Author

jablko commented May 10, 2022

@jablko jablko force-pushed the patch-1 branch 2 times, most recently from 2358e7c to 7ababba Compare May 10, 2022 19:56
@jablko
Copy link
Contributor Author

jablko commented May 10, 2022

@dmitry-shibanov I noticed:

  1. The e2e test exposed a mistake I made and have now corrected.
  2. The lts-syntax e2e test was missing a "Verify node and npm" step like the other versions.yml jobs, so I added that too.

@jablko
Copy link
Contributor Author

jablko commented May 13, 2022

I've rebased and combined the repetitive LTS tests with it.each(table) --- but I'm happy to leave them unrolled if you prefer?

@dmitry-shibanov
Copy link
Contributor

Hello @jablko. Could you please sync with the main branch ?

@jablko
Copy link
Contributor Author

jablko commented May 30, 2022

@dmitry-shibanov
Copy link
Contributor

Hello @jablko. I think we should not reverse initial manifest. If we specify check-latest to true the action won't return the latest lts version for lts aliases.

The code return the major version that is why when searching for a satisfied version in the reversed array, not the latest version will be taken.

@jablko
Copy link
Contributor Author

jablko commented May 30, 2022

Thanks @dmitry-shibanov, you're right, tc.findFromManifest() depends on the manifest's order.

  • I've added an entry to the unit tests' mock manifest, so one of its major versions has at least two minor versions, which exposes my mistake. Then I removed the .reverse() and confirmed the tests pass again and we get the max satisfying version when check-latest is true.

Copy link

@callree callree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI

kodiakhq bot added a commit to 3x071c/lsg-musin that referenced this pull request Oct 9, 2022
This PR contains the following updates:



Package
Change
Age
Adoption
Passing
Confidence
Type
Update




@astrojs/partytown (source)
1.0.0 -> 1.0.1




dependencies
patch


@picocss/pico (source)
1.5.5 -> 1.5.6




dependencies
patch


@types/node (source)
18.7.23 -> 18.8.3




devDependencies
minor


actions/checkout
v3.0.0 -> v3.1.0




action
minor


actions/setup-node
v3.0.0 -> v3.5.0




action
minor


actions/stale
v6.0.0 -> v6.0.1




action
patch


astro (source)
1.3.1 -> 1.4.6




dependencies
minor


astro-netlify-cms
0.2.2 -> 0.2.3




dependencies
patch


cspell (source)
6.10.1 -> 6.12.0




devDependencies
minor


eslint (source)
8.24.0 -> 8.25.0




devDependencies
minor


eslint-plugin-astro (source)
0.19.0 -> 0.20.0




devDependencies
minor


nick-fields/retry
v2.6.0 -> v2.8.1




action
minor


postcss (source)
8.4.16 -> 8.4.17




devDependencies
patch


prettier-plugin-astro
0.5.4 -> 0.5.5




devDependencies
patch


prettier-plugin-prisma
4.2.0 -> 4.4.0




devDependencies
minor


vite (source)
3.1.4 -> 3.1.6




devDependencies
patch




Release Notes

withastro/astro (@​astrojs/partytown)
v1.0.1
Compare Source
Patch Changes

#​4989 50a397c4b Thanks @​that-joao! - Update @​builder.io/partytown dependency



picocss/pico
v1.5.6
Compare Source
Features

Adds the ability to compile Pico with a root element other than body (E.g. #__next, #___gatsby, #root), by @​ja1den
Define your your CSS selector in scss/_variables.scss > $semantic-root-element
#​224 #​13 #​222

Fixes

aria-invalid for dates input, by @​rbf
#​242 #​243

Documentation

Improves Customization and Class-less pages
#​245

Full changelog
A huge thank you to all the contributors ❤️


actions/checkout
v3.1.0
Compare Source

Use @​actions/core saveState and getState
Add github-server-url input

v3.0.2
Compare Source

Add input set-safe-directory

v3.0.1
Compare Source

Fixed an issue where checkout failed to run in container jobs due to the new git setting safe.directory
Bumped various npm package versions



actions/setup-node
v3.5.0
Compare Source
In scope of this release we add support for engines.node. The action will be able to grab the version form package.json#engines.node. actions/setup-node#485. Moreover, we added support for Volta
Besides, we updated @​actions/core to 1.9.1 and @​actions/cache to 3.0.4
v3.4.1
Compare Source
In scope of this release we fixed bugs related to the pnpm 7.5.1 output issue from pnpm store path actions/setup-node#545. Moreover we fixed the issue with falling on node-version output actions/setup-node#540.
v3.4.0
Compare Source
In scope of this release we updated actions/cache package as the new version contains fixes for caching error handling. Moreover, we added support for asdf format as Node.js version file actions/setup-node#373. Besides, we introduced new output node-version and added npm-shrinkwrap.json to dependency file patterns: actions/setup-node#439
v3.3.0
Compare Source
In scope of this release we added support for lts/-n aliases, improve logic for current, latest and node aliases to handle them from toolcache, update ncc package.
Support of lts/-n aliases

Related pull request: actions/setup-node#481
Related issue: actions/setup-node#26

steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
  with:
    node-version: lts/-1
- run: npm ci
- run: npm test
Minor improvements

Update zeit/ncc to vercel/ncc: actions/setup-node#476
Get latest version from cache if exists: actions/setup-node#496

v3.2.0
Compare Source
In scope of this release we added new aliases to install the latest Node.js version. actions/setup-node#483
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
  with:
    node-version: current
- run: npm ci
- run: npm test
v3.1.1
Compare Source
In scope of this release we updated actions/cache package as the new version contains fixes related to GHES 3.5 (actions/setup-node#460)
v3.1.0
Compare Source
In scope of this release we added support for caching from GHES 3.5 and fixed download issue for files > 2GB during restore. Besides, we updated actions/cache dependency to 2.0.0 version.


actions/stale
v6.0.1
Compare Source
Update @​actions/core to 1.10.0 #​839
Full Changelog: actions/stale@v6.0.0...v6.0.1


withastro/astro (astro)
v1.4.6
Compare Source
Patch Changes

#​5013 ffbe4e71e Thanks @​matthewp! - Fixes getViteConfig from astro/config

v1.4.5
Compare Source
Patch Changes


#​4981 1f890b336 Thanks @​matthewp! - Ensure dynamic tags have their slot instructions yielded


#​4886 61d26f335 Thanks @​yuhang-dong! - Fix: import.meta.env.BASE_URL will be '/' in client loaded component on dev mode


#​4973 c733d4fb8 Thanks @​bluwy! - Support Astro.slots.render for mdx


#​4918 a6bb2694b Thanks @​bluwy! - Refactor hydration path handling


#​4977 4f73b98ae Thanks @​tony-sull! - Fixes a bug that logged route cache warnings in astro dev


#​4887 37cb2fc02 Thanks @​Calvin-LL! - fix object styles not escaped


#​4990 8f9791d84 Thanks @​matthewp! - Upgrade Astro compiler to 0.26.0


v1.4.4
Compare Source
Patch Changes


#​4967 e6a881081 Thanks @​matthewp! - Final perf fix from 1.3.0 regression
A regression in rendering perf happened in 1.3.0. This is the final fix for the underlying issue.


v1.4.3
Compare Source
Patch Changes


#​4956 ee8dd424f Thanks @​matthewp! - Fix perf regression in SSR


#​4952 5bcd76e3a Thanks @​bluwy! - Refactor ViteConfigWithSSR type


v1.4.2
Compare Source
Patch Changes


#​4932 9898088c0 Thanks @​matthewp! - Prevent hydration mismatch in streaming SSR


#​4939 cf2bba1e4 Thanks @​natemoo-re! - Fix MDX error handling, preventing a memory leak


v1.4.1
Compare Source
Patch Changes

#​4928 7690849a8 Thanks @​Princesseuh! - Fix module definition of Markdown and MDX files not being available outside Astro files

v1.4.0
Compare Source
Minor Changes


#​4907 01c1aaa00 Thanks @​matthewp! - Order Astro styles last, to override imported styles
This fixes CSS ordering so that imported styles are placed higher than page/component level styles. This means that if you do:




delucis/astro-netlify-cms
v0.2.3
Compare Source
Patch Changes

#​23 26243d5 Thanks @​codelastnight! - remove node join() from vite-plugin-admin-dashboard to allow windows to run dev



streetsidesoftware/cspell
v6.12.0
Compare Source
Features

Use cspell-dictionary Module (#​3686) (6441f4b)

6.11.1 (2022-09-30)
Bug Fixes

Fix export of SpellingDictionaryCollection (#​3683) (7665cdb)

v6.11.1
Compare Source
Bug Fixes

Fix export of SpellingDictionaryCollection (#​3683) (7665cdb)

v6.11.0
Compare Source
Note: Version bump only for package cspell-monorepo
6.10.1 (2022-09-20)
Note: Version bump only for package cspell-monorepo


eslint/eslint
v8.25.0
Compare Source
Features

173e820 feat: Pass --max-warnings value to formatters (#​16348) (Brandon Mills)
6964cb1 feat: remove support for ignore files in FlatESLint (#​16355) (Milos Djermanovic)
1cc4b3a feat: id-length counts graphemes instead of code units (#​16321) (Sosuke Suzuki)

Documentation

90c6028 docs: Conflicting fixes (#​16366) (Ben Perlmutter)
5a3fe70 docs: Add VS to integrations page (#​16381) (Maria José Solano)
49bd1e5 docs: remove unused link definitions (#​16376) (Nick Schonning)
3bd380d docs: typo cleanups for docs (#​16374) (Nick Schonning)
b3a0837 docs: remove duplicate words (#​16378) (Nick Schonning)
a682562 docs: add BigInt to new-cap docs (#​16362) (Sosuke Suzuki)
f6d57fb docs: Update docs README (#​16352) (Ben Perlmutter)
7214347 docs: fix logical-assignment-operators option typo (#​16346) (Jonathan Wilsson)

Chores

1f78594 chore: upgrade @​eslint/eslintrc@​1.3.3 (#​16397) (Milos Djermanovic)
8476a9b chore: Remove CODEOWNERS (#​16375) (Nick Schonning)
720ff75 chore: use "ci" for Dependabot commit message (#​16377) (Nick Schonning)
42f5479 chore: bump actions/stale from 5 to 6 (#​16350) (dependabot[bot])
e5e9e27 chore: remove jsdoc dev dependency (#​16344) (Milos Djermanovic)



ota-meshi/eslint-plugin-astro
v0.20.0
Compare Source
Minor Changes

#​116 9c481f8 Thanks @​renovate! - update dependency astro-eslint-parser to ^0.7.0



nick-fields/retry
v2.8.1
Compare Source
Refactor to make testing easier
v2.8.0
Compare Source
Use spawn rather than exec to support much larger outputs

Should resolve #​84  and #​76

v2.7.1
Compare Source
This release contains mostly dependency updates. There are a few very minor changes to runtime code based on development quality of life improvements from newly configured linting and styling.
v2.7.0
Compare Source
Features

retry only on specific exit code (#​58) (f227091)

Misc

Various dependabot updates



postcss/postcss
v8.4.17
Compare Source

Fixed Node.before() unexpected behavior (by Romain Menke).
Added TOC to docs (by Mikhail Dedov).



withastro/prettier-plugin-astro
v0.5.5
Compare Source
Patch Changes

fe68b94: Fix missing newline after attributes on inline elements when using singleAttributePerLine
96e2b28: Fix expressions not hugging the end of the tag in cases where they should
4e6fde8: Fix newlines being added to style tags even if they were empty



umidbekk/prettier-plugin-prisma
v4.4.0
Compare Source

feat: Bump @prisma/prisma-fmt-wasm to 4.4.0.  7e2fd9a

v4.3.0
Compare Source

feat: Bump @prisma/prisma-fmt-wasm to 4.3.0.  71f66fe
chore: Bump dependencies.  d976203



vitejs/vite
v3.1.6
Compare Source
Please refer to CHANGELOG.md for details.
v3.1.5
Compare Source
Please refer to CHANGELOG.md for details.


Configuration
📅 Schedule: Branch creation - "before 2am" in timezone Europe/Berlin, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


 If you want to rebase/retry this PR, click this checkbox.


This PR has been generated by Mend Renovate. View repository job log here.
deining pushed a commit to deining/setup-node that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants