Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Actions for CI #1349

Merged
merged 1 commit into from Jan 6, 2022
Merged

Use GitHub Actions for CI #1349

merged 1 commit into from Jan 6, 2022

Conversation

coldlink
Copy link
Member

@coldlink coldlink commented Jan 5, 2022

What does this change?

Switches CI from TeamCity to GitHub Actions (with the use of https://github.com/guardian/actions-assume-aws-role).

There are a few benefits to using GHA individually:

  • No build queue
  • No need to manage node docker versions
  • No need to globally install yarn
  • Build logs are co-located with the PR (via the Checks tab)
  • Collectively, use of GHA means we don't have to maintain our own CI infrastructure.

In RiffRaff the build numbers will count up from 5000 now, as the teamcity builds are currently in the 4000s.

To help perform the migration, I used migration doc and example prs from Prism and tag-janitor.

How to test

identity:identity-gateway should appear as a deployable project in Riff-Raff. It should be successfully deployed to CODE.

https://riffraff.gutools.co.uk/deployment/view/efa79594-2d2f-4b0d-8339-3e591bf3873f

Pre merge

  • Change the branch protection rules to remove TeamCity from required, and add the CI Github Action to required

Post merge

  • Ask people to rebase their branches on main to deploy to CODE/PROD going forward
  • Remove project from TeamCity

@coldlink coldlink changed the title ci: use github actions for ci Use GitHub Actions for CI Jan 5, 2022
@coldlink coldlink marked this pull request as ready for review January 5, 2022 15:55
@coldlink coldlink requested a review from a team as a code owner January 5, 2022 15:55
ci.sh Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
ci.sh Outdated Show resolved Hide resolved
@coldlink coldlink force-pushed the mm/ci-gha branch 2 times, most recently from 98b2a4c to 6c36175 Compare January 5, 2022 16:41
@coldlink coldlink requested a review from a team January 5, 2022 16:42
ci.sh Show resolved Hide resolved
@coldlink coldlink merged commit a4b6c1d into main Jan 6, 2022
@coldlink coldlink deleted the mm/ci-gha branch January 6, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants