Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js 12 to 16 #1047

Closed
LyKos4 opened this issue Dec 14, 2022 · 7 comments
Closed

Node.js 12 to 16 #1047

LyKos4 opened this issue Dec 14, 2022 · 7 comments

Comments

@LyKos4
Copy link

LyKos4 commented Dec 14, 2022

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the action to use Node.js 16

@ebrannin-bw
Copy link

From this comment on #959, it seems like the way to resolve this is to upgrade to v3.

@vanZeben
Copy link
Contributor

As noted above from @ebrannin-bw, upgrading to use actions/checkout@v3 should correct the deprecations. If it doesn't, please re-open this with some more information about your workflow :)

max-m added a commit to max-m/SameBoy that referenced this issue Dec 30, 2022
max-m added a commit to max-m/SameBoy that referenced this issue Dec 30, 2022
@Vadorequest
Copy link

The issue with upgrading to v3 is to have to deal with the major bumps, and all it entails (probably little, but still).

The issue becomes really tough to deal with when you multiply this by the number of actions that needs to be upgraded to node16, and then do this for all repositories. (as manager of dozens of repos, this is heavy work)

UnlyEd/github-action-await-vercel#74 (comment)

It'd be easier if actions/checkout@v2 would be migrated to v16 directly.

And it'd be awesome if that became some sort of "best practice" (assuming it doesn't break other things), so as to avoid having to change the major version of all our actions that aren't yet up-to-date.

@Vadorequest
Copy link

After reading changelog, it appears the v3 was created specifically because of the nodejs v16 upgrade.

So, I guess there are reasons not to do that upgrade in @v2 directly... but that does create a ton of needless work

NovaSagittarii added a commit to citrushack/citrushack2023 that referenced this issue Mar 15, 2023
maybe node v12 is causing issues and v16 makes it go away actions/checkout#1047
saladuit added a commit to saladuit/minishell that referenced this issue Apr 11, 2023
`As noted above from @ebrannin-bw, upgrading to use actions/checkout@v3 should correct the deprecations. If it doesn't, please re-open this with some more information about your workflow :)`
actions/checkout#1047
@yeeydu
Copy link

yeeydu commented May 5, 2023

changing to actions/checkout@v3 doesn´t work for me

@ntimpj
Copy link

ntimpj commented May 6, 2023

actions/checkout@v3 doesn´t work for me either

@yeeydu
Copy link

yeeydu commented May 10, 2023

Hi, after changing to actions/checkout@v3 i notice that there was a access_token validation error. So i just paste back the original code and went to settings-actions-workflow permissions and change permissions.

if that could be your problem. you just have to allow read and write permissions in the workflow permissions.

Captura de ecrã 2023-05-10, às 09 54 09

Go down a bit to see workflow permissions.

Captura de ecrã 2023-05-10, às 09 55 29

Hope this works for you!!

RonaldVisser added a commit to RonaldVisser/Zotero_werkcollege that referenced this issue Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants