Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to checkout v3 (to use node.js 16 and get rid of a warning) #12

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Update to checkout v3 (to use node.js 16 and get rid of a warning) #12

merged 1 commit into from
Sep 13, 2023

Conversation

Trost123
Copy link
Contributor

@Trost123 Trost123 commented Apr 22, 2023

Use actions/checkout@v3 instead of v2 to get rid of node version warnings.

Details: the workflow was loggin a warning:

deploy
Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

I found this thread and found out that bumping the version of checkout to v3 gets rid of this warning.
Tested the workflow after this change and seems to be working just fine, without throwing this warning. 馃憤

Use actions/checkout@v3 instead of v2 to get rid of node version warnings.
@Trost123 Trost123 changed the title Update main.yml Update to checkout v3 (to used node 16) Apr 22, 2023
@Trost123 Trost123 changed the title Update to checkout v3 (to used node 16) Update to checkout v3 (to use node.js 16 and get rid of a warning) Apr 22, 2023
fangohr added a commit to fangohr/oommf that referenced this pull request Jul 7, 2023
It actually said:

Node.js 12 actions are deprecated. Please update the following actions to use
Node.js 16: actions/checkout@v2. For more information see:
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

Some googling suggests this commit should fix
it (timovv/notion-website-template#12)
@timovv
Copy link
Owner

timovv commented Sep 13, 2023

Hi @Trost123, thank you for the PR and investigation! Much appreciated (and sorry for taking so long to get it merged!)

@timovv timovv merged commit 65c69a5 into timovv:main Sep 13, 2023
@Trost123 Trost123 deleted the use-checkout-v3 branch September 13, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants