Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigating build failure #51

Merged
merged 3 commits into from
Apr 12, 2023
Merged

Investigating build failure #51

merged 3 commits into from
Apr 12, 2023

Conversation

andyjdavis
Copy link
Contributor

@andyjdavis andyjdavis commented Apr 11, 2023 •
edited

Branched from #50 which has failing builds

Problems Resolved:

  1. .github/workflows/test.yml references actions/checkout@v2 which uses the now deprecated node 12. v3 defaults to node 16.

Some links about that:
actions/checkout#1047
https://github.com/actions/checkout/blob/main/CHANGELOG.md#v300

  1. Rubocop offenses. Specifically several instances of the below.
lib/rack/ecg/check_registry.rb:43:5: W: [Correctable] Layout/EndAlignment: end at 43, 4 is not aligned with class at 33, 6.
    end
    ^^^

dependabot bot and others added 3 commits March 14, 2023 19:58
@dependabot
Update rack-test requirement from ~> 2.0.2 to ~> 2.1.0
42ce9d5 
Updates the requirements on [rack-test](https://github.com/rack/rack-test) to permit the latest version.
- [Release notes](https://github.com/rack/rack-test/releases)
- [Changelog](https://github.com/rack/rack-test/blob/main/History.md)
- [Commits](rack/rack-test@v2.0.2...v2.1.0)

---
updated-dependencies:
- dependency-name: rack-test
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@andyjdavis
Updating the github checkout action to use a newer node version
f1e2ba5
@andyjdavis
fixing rubocop offenses
df1989c
liamdawson
liamdawson approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@liamdawson liamdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@liamdawson liamdawson merged commit fd78745 into main Apr 12, 2023
6 checks passed
@orien orien deleted the investigatingBuildFailure branch February 5, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamdawson liamdawson liamdawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andyjdavis @liamdawson