Adding Whitesource Scan to Build Workflow #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shooshmand-sol
requested review from
johnvincentcorpuz,
amanek-solace and
gregmeldrum
shooshmand-sol
commented
May 10, 2023
| @@ -23,7 +23,7 @@ jobs: | |||
| contents: read | |||
| packages: write | |||
| steps: | |||
| - uses: actions/checkout@v2 | |||
| - uses: actions/checkout@v3 | |||
There was a problem hiding this comment.
upversion the plugin, to address this warning: actions/checkout#1047
johnvincentcorpuz
approved these changes
May 11, 2023
.github/workflows/build.yaml
Outdated
| @@ -37,6 +37,16 @@ jobs: | |||
| export SKIP_FLAGS_NON_UNIT_TESTS="-Dcheckstyle.skip -Dpmd.skip -Dcpd.skip -Dfindbugs.skip -Dspotbugs.skip" | |||
| echo "SKIP_FLAGS_NON_UNIT_TESTS=$SKIP_FLAGS_NON_UNIT_TESTS" >> $GITHUB_ENV | |||
| echo "SKIP_FLAGS_ALL_TESTS=$SKIP_FLAGS_NON_UNIT_TESTS -Dmaven.test.skip=true" >> $GITHUB_ENV | |||
| if [[ $GITHUB_EVENT_NAME != "pull_request" && $GITHUB_REF_NAME=="main" ]]; then | |||
There was a problem hiding this comment.
Trying to remember here the case where GITHUB_EVENT_NAME==pull_request and GITHUB_REF_NAME=="main". Why did we have to specify != pull_request?
There was a problem hiding this comment.
Good point, I also realized that $GITHUB_EVENT_NAME != "pull_request" is not necessary, for PRs GITHUB_REF_NAME vaule is pr_number/merge;
so going to drop that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
Adding Whitesource Scan to Build Workflow
How was this change implemented?
Whitesource scan step added to the build workflow, which does:
wss-unified-agent.jarscan againsttarget/libfolderWS_EXCLUDESHow was this change tested?