Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript 4.5 #1350

Closed
wants to merge 20 commits into from
Closed

Typescript 4.5 #1350

wants to merge 20 commits into from

Commits on Dec 22, 2021

  1. TypeScript 4.5 and Prettier 2.5 (for TS 4.5 syntax support

    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    9be1598 View commit details
    Browse the repository at this point in the history

  2. Drop deprectaed prettier rule jsxBracketSameLine

    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    a2df49c View commit details
    Browse the repository at this point in the history

  3. Update eslint from 7 to 8, corresponding versions of @typescript-eslint… 

    … for TS 4.5 support
    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    996f56e View commit details
    Browse the repository at this point in the history

  4. Rename root package.json prettier scripts, add eslint scripts

    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    81c6f1f View commit details
    Browse the repository at this point in the history

  5. Add a prettier write call post eslint:fix, closes #1213

    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    355946b View commit details
    Browse the repository at this point in the history

  6. Change prettier:write log level to warn, default logging is overly ve… 

    …rbose
    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    ff6663f View commit details
    Browse the repository at this point in the history

  7. Use consistent, desired, configuration for no-unused-vars in both js … 

    …and ts (warn, but ignore arguments starting with an _)
    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    1f96213 View commit details
    Browse the repository at this point in the history

  8. Centralize eslint ignore rules at top level, like we have with the pr… 

    …ettier ignores. Simplifies running project-wide linting
    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    db31144 View commit details
    Browse the repository at this point in the history

  9. Misc linting

    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    3d285c1 View commit details
    Browse the repository at this point in the history

  10. Sort out linting in root scripts, fix some lint errors there and in f… 

    …orm_backend
    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    4113640 View commit details
    Browse the repository at this point in the history

  11. Lint instance of no-use-before-define in server code

    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    ec791eb View commit details
    Browse the repository at this point in the history

  12. Add stand alone repo-wide lint job to CI

    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    c01f377 View commit details
    Browse the repository at this point in the history

  13. Configure repo wide eslint command to cache

    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    83c5532 View commit details
    Browse the repository at this point in the history

  14. Make use of eslint caches in CI lint job

    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    bacfb4c View commit details
    Browse the repository at this point in the history

  15. Lint no-unused-vars in form_backend and server

    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    aa77483 View commit details
    Browse the repository at this point in the history

  16. Extract CI install steps to fragments, to make sure cache keys are co… 

    …nsistently used. Add all installs to project-wide lint job to make sure necessary eslint plugins are all installed (might not be worth having this centralized lint job afterall, hmm)
    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    ec4d093 View commit details
    Browse the repository at this point in the history

  17. Ah, CircleCI has a "commands" syntax for reusable blocks of steps, th… 

    …at's good because whatever I was trying with yaml fragments wasn't going to work, ha
    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    6ae8ed4 View commit details
    Browse the repository at this point in the history

  18. Set max warnings to 0 for repo wide eslint scan, mainly so CI gets th… 

    …e non 0 exit status on warnings as well as errors too
    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    02d3a2c View commit details
    Browse the repository at this point in the history

  19. Fix rest arg error introduced by removing an unused var in the server… 

    … people popuate code
    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    2bc831a View commit details
    Browse the repository at this point in the history

  20. Set ignoreRestSiblings: true in no-unused-vars lint rule, a bit of a … 

    …gotcha when left on the default false (and trying to fix a large numer of these quickly, ha)
    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    640bae6 View commit details
    Browse the repository at this point in the history